Repository navigation
feat(desktop): continue a passkey sign-in in your browser and bring the session back - #9515
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Critical impact] The PR appears safe to merge, with a non-blocking stale-notice issue after a failed replacement launch. Findings
SummaryAdds a browser escape hatch for passkey sign-ins:
One non-blocking issue remains: a failed replacement launch leaves an old sign-in notice in the renderer.
|
There was a problem hiding this comment.
All reported issues were addressed across 31 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
b368cf8 to
457fdc2
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 32 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…he session back - From an agent browser tab, open the page in a chosen Chrome-family profile, finish the sign-in there, then bring that site's cookies back - Per-site import scoped to the page's registrable domain (tldts, private suffixes respected), filtered in SQL and checked per row before decryption - One pending handoff per chat in main; a remounted panel restores its Bring session back notice - Subtle hint on known sign-in hosts; hidden on older shells, off macOS, or with no Chromium browser installed
… and sign-out Retire in-flight launches on cancel, newer continue, and account teardown; move a provisional chat's handoff with its browser scope; skip reopening the tab when a bring-back's handoff was superseded; pin the platform in the continue-sign-in tests so they pass on Linux CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n shell support Re-read the chat's pending sign-in after any continue result so a failed launch that retired the previous handoff cannot leave a stale notice, and require the shell's continue-sign-in bridge before showing the feature, since the profiles cache is shared with the import dialog on older shells. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
457fdc2 to
35c64f8
Compare
Summary
open -n -b <bundleId> --args --profile-directory=…(no shell); a notice then offers Bring session back, which imports that site's cookies and reloads the original tabtldts, private suffixes respected), filtered in SQL and checked per row before decryption; whole-profile import is unchangedBrowserNoticenow also backs the theme notice; the profile list is one React Query query shared with the browser import dialogType of Change
Testing
site-scope.test.ts(scope leaks: lookalikes,github.iotenants, IP/localhost exact, leading dots),chromium-cookies.test.ts(out-of-scope rows never decrypted or counted),import-service.test.ts, newbrowser-import/index.test.ts(continue/bring-back/cancel/race),ipc.test.ts(gesture/origin gating, renderer URL ignored, closed-tab reopen),sign-in-hosts.test.ts, browser-session suitee2e/continue-sign-in.spec.ts(real Electron, JSON report): feature present with no browsers offered when none installed; scripted call without a click refused; main reads the tab URL and refuses httptsc --noEmit, changed-file type-check in apps/sim, biome,check:desktop-ipc,check:desktop-bridge,check:react-query,check:comment-hygiene; full gate in CIChecklist
test-auditauthoring gate)