Repository navigation
improvement(cli): files batch-delete takes file ids as arguments - #9518
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge; the latest docs baseline update matches the changed examples. Summary
Reviews (2) · Last reviewed commit: "chore(docs): record the batch-delete usa..." · Reviewed by Greptile |
|
Docs compatibility: this PR intentionally changes one public code example, the |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
sim files batch-delete <id> <id> --yesnow works: the ids may follow the command as arguments, exactly likerm, as well as through--file-idsrequired option '--file-ids <value...>' not specifiedand cost a retry or a--helpround triptrailingflag spec: one list field per command may also take trailing arguments. Values fold into the list flag before the request is built, so@pathmanifests, validation and the--yesgate apply unchanged; passing both forms is refused, and a missing value still fails with--file-ids is requiredfiles batch-delete; every other command's parsing is unchanged--file-idsnow reads "required, or pass the values as arguments")Type of Change
Testing
packages/sim-cli/src/runtime/trailing-list.test.tsthroughrunEmbeddedCli(the path Mothership uses), capturing the real request: positional ids send the same body as--file-ids; both forms, and neither, are refused before any request; the--yesconfirmation still applies. 3/3 pass; withtrailingremoved all 3 failbun run lint,check:cli-api,check:cli-docs,check:openapi,check:mcp-operations,check:utils,check:comment-hygiene,check:test-patterns,check:explicit-any,check:file-names,check:source-conventionscheck:auditsand the test suites run in CIChecklist
test-auditauthoring gate)