Skip to content

fix(mothership): say why a workflow copilot chat cannot read other chats - #9520

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/recall-chats-honest-refusal
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/recall-chats-honest-refusal

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • history search --chats from a workflow's copilot chat is refused by design (other chats are read back from home chats only), but the refusal said Chat not found about the caller's own, existing chat
  • The agent read that as a transient lookup failure and retried the identical command, up to three times in one chat
  • The refusal is now forbidden with the reason: "Reading other chats is available in home chats, not in a workflow's copilot chat", matching the neighboring "requires an agent chat" refusal. No concealment is lost: it is the caller's own chat, refused after authorization
  • What is listed, and for whom, is unchanged; the worker already surfaces Sim's refusal text and status for any non-OK answer

Type of Change

  • Bug fix

Testing

  • lib/mothership/chat/application/read-recall-chats.test.ts: the workflow-chat case now asserts the forbidden code and reason; 13/13 pass, and it fails against the previous not_found
  • bun run lint, check:api-validation:strict, check:comment-hygiene, check:test-patterns, check:utils, check:source-conventions
  • Type-check, full check:audits and the test suites run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 9:06am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Changes the workflow-chat refusal from not_found to forbidden and explains that reading other chats is available only from home chats.

  • Workflow copilot chats get a clear reason when they cannot read other chats.

Reviews (1) · Last reviewed commit: "fix(mothership): say why a workflow copi..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2db94a5 into staging Oct 31, 2026
70 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/recall-chats-honest-refusal branch October 31, 2026 17:45

This branch was previously deployed

1 inactive deployment
Preview — 12c97385 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant