Repository navigation
fix(mothership): say why a workflow copilot chat cannot read other chats - #9520
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This PR appears safe to merge. SummaryChanges the workflow-chat refusal from
Reviews (1) · Last reviewed commit: "fix(mothership): say why a workflow copi..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history search --chatsfrom a workflow's copilot chat is refused by design (other chats are read back from home chats only), but the refusal saidChat not foundabout the caller's own, existing chatforbiddenwith the reason: "Reading other chats is available in home chats, not in a workflow's copilot chat", matching the neighboring "requires an agent chat" refusal. No concealment is lost: it is the caller's own chat, refused after authorizationType of Change
Testing
lib/mothership/chat/application/read-recall-chats.test.ts: the workflow-chat case now asserts theforbiddencode and reason; 13/13 pass, and it fails against the previousnot_foundbun run lint,check:api-validation:strict,check:comment-hygiene,check:test-patterns,check:utils,check:source-conventionscheck:auditsand the test suites run in CIChecklist
test-auditauthoring gate)