Skip to content

improvement(cli): sim credentials providers lists providers - #9522

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/cli-subgroup-default
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/cli-subgroup-default

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • sim credentials providers now lists credential providers, the same request as sim credentials providers list (which keeps working)
  • Agents consistently treat the providers group as the list (credentials providers | grep -i github) and got the group's usage text back instead of results, costing a retry
  • New defaultSubcommand leaf flag: the leaf is registered as its group's default with Commander's native isDefault, so the group keeps no options of its own and the leaf parses its options in either spelling (credentials providers --search x and credentials providers list --search x). Variants never inherit it. Applied only to listCredentialProviders, whose group holds nothing but that list
  • No other command, group, or generated doc changes (check:cli-docs and the docs compatibility check are unchanged)

Type of Change

  • Improvement

Testing

  • New packages/sim-cli/src/runtime/group-default.test.ts through runEmbeddedCli, capturing the real request: the bare group sends GET /api/v2/credentials/providers exactly as list does; --search github reaches the request as search=github in both spellings; a group without a default (credentials) still prints usage and sends nothing. 3/3 pass; the bare-group and option cases fail without the flag
  • Related sim-cli suites (build, options, execute, commands, reference, embed isolation): 141 runtime + 19 contract tests pass
  • bun run lint, check:cli-docs, check:cli-api, content:verify-compatibility, check:utils, check:comment-hygiene, check:test-patterns, check:explicit-any, check:file-names, check:source-conventions
  • Type-check, full check:audits and the test suites run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 9:20am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no blocking issue remains.

Summary

Makes sim credentials providers run the existing list command through Commander’s isDefault option.

  • The credentials providers group lists credential providers directly.

No new actionable issues found. Tests were inspected but not run.

Reviews (2) · Last reviewed commit: "improvement(cli): sim credentials provid..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the improvement/cli-subgroup-default branch from 994a967 to 85b5b1a Compare October 31, 2026 09:19
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a4519ea into staging Oct 31, 2026
70 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/cli-subgroup-default branch October 31, 2026 17:45

This branch was previously deployed

1 inactive deployment
Preview — 85b5b1a1 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant