Repository navigation
improvement(cli): sim credentials providers lists providers - #9522
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge; no blocking issue remains. SummaryMakes
No new actionable issues found. Tests were inspected but not run. Reviews (2) · Last reviewed commit: "improvement(cli): sim credentials provid..." · Reviewed by Greptile |
waleedlatif1
force-pushed
the
improvement/cli-subgroup-default
branch
from
October 31, 2026 09:19
994a967 to
85b5b1a
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim credentials providersnow lists credential providers, the same request assim credentials providers list(which keeps working)credentials providers | grep -i github) and got the group's usage text back instead of results, costing a retrydefaultSubcommandleaf flag: the leaf is registered as its group's default with Commander's nativeisDefault, so the group keeps no options of its own and the leaf parses its options in either spelling (credentials providers --search xandcredentials providers list --search x). Variants never inherit it. Applied only tolistCredentialProviders, whose group holds nothing but that listcheck:cli-docsand the docs compatibility check are unchanged)Type of Change
Testing
packages/sim-cli/src/runtime/group-default.test.tsthroughrunEmbeddedCli, capturing the real request: the bare group sendsGET /api/v2/credentials/providersexactly aslistdoes;--search githubreaches the request assearch=githubin both spellings; a group without a default (credentials) still prints usage and sends nothing. 3/3 pass; the bare-group and option cases fail without the flagbun run lint,check:cli-docs,check:cli-api,content:verify-compatibility,check:utils,check:comment-hygiene,check:test-patterns,check:explicit-any,check:file-names,check:source-conventionscheck:auditsand the test suites run in CIChecklist
test-auditauthoring gate)