Repository navigation
fix(execution): name the signal that killed a sandbox process in its error - #9523
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThe PR adds exit-code descriptions to sandbox errors while keeping the process’s printed output.
Reviews (2) · Last reviewed commit: "fix(execution): describe a signal's exit..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
128 + ncode, followed by the process's own output:Process exited with code 137 (the exit code of SIGKILL, usually out of memory): <stderr>. The code alone cannot prove a kill (a program may exit 137 itself), so it is described as the signal's code, not asserted128 + nexit code the same exit description is appended (<value> [Process exited with code 137 (…)]), so neither a program's own error nor the exit code is lost. Other exit codes are unchangedrun_codeand workflow Function blocks; nothing parses the messageType of Change
Testing
lib/execution/remote-sandbox/conformance.test.ts(E2B and Daytona): a command killed with 137 after printing a warning reports the signal first and keeps the warning; fails on staging for both providers. The existing "real command output" case still holdslib/execution/remote-sandbox/code-failure.test.ts: a printed headline survives a 137 exit with the exit description appended, and exit code 1 is unchanged; exit-code descriptions at 1, 128, 129, 143 and 193bun run lint,check:utils,check:comment-hygiene,check:test-patterns,check:explicit-any,check:source-conventionscheck:auditsand the test suites run in CIChecklist
test-auditauthoring gate)