Repository navigation
fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases - #9547
Merged
Conversation
…ked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR strengthens desktop restart warnings and fixes image saves, sign-in hints, and manager status text.
Reviews (1) · Last reviewed commit: "fix(desktop): address release review — c..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 22 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work:
DownloadItems are now tracked indownloads.tsand summed with agent-browser downloadsreadForegroundProcessGroupreturnsshell | group | unknowninstead ofnullfor both "the shell owns the foreground" and "the probe failed".unknownnow prompts ("A terminal couldn't be checked and may still be running a command."); a dead shell pid reads as idle; Windows skipsps;stopCommandstill never escalates without a confirmed group. Results fold in stable session order, and unnamed commands read "N terminal commands are still running." instead of "a command and a command"browser-agent/referrer.ts, with the existing menu referrer helpers moved there) computes the header Electron'sdownloadURLmaps into Chromium's download referrer: no-referrer, origin-only cross-origin by default, none on an https→http downgrade, credentials and fragment stripped, oversize → origincontinuablePagerefuses URLs carrying credentials, matching the shell'sisSafeExternalUrl; the notice's TSDoc no longer claims one line (it wraps on purpose)Type of Change
Testing
downloads.test.ts,in-flight-work.test.ts,updater.test.ts,terminal/service.test.ts, newterminal/process-group.test.ts(real exited pid → idle), newbrowser-agent/referrer.test.ts,sign-in-hosts.test.ts— new cases red on the pre-fix codee2e/browser-page-parity.spec.ts: the image fixture now refuses requests without a Referer and records it; Save Image asserts the full page URL was sent (fails with the baredownloadURL)tsc --noEmit, targeted apps/sim type-check, biome; full gate in CIChecklist
test-auditauthoring gate)