Skip to content

fix(desktop): address release review — count app downloads and unchecked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases - #9547

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/release-review-comment-fixes
Nov 1, 2026

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Verified review findings from the v0.9.39 release PR (#9544) on this session's desktop and people work:

  • Update restart counts app-window downloads. Large Files-page downloads start a native download from the app window that the in-flight check didn't see, so "Restart to update" could cut one off with no warning. App-window DownloadItems are now tracked in downloads.ts and summed with agent-browser downloads
  • Unreadable terminals are no longer treated as idle. readForegroundProcessGroup returns shell | group | unknown instead of null for both "the shell owns the foreground" and "the probe failed". unknown now prompts ("A terminal couldn't be checked and may still be running a command."); a dead shell pid reads as idle; Windows skips ps; stopCommand still never escalates without a confirmed group. Results fold in stable session order, and unnamed commands read "N terminal commands are still running." instead of "a command and a command"
  • A failing in-flight check asks instead of restarting silently ("Sim couldn't check whether restarting would interrupt any work.")
  • Consumed relaunch routes are flushed immediately, so a crash right after an update relaunch can't reopen the same windows again
  • Save Image sends the page's referrer. Referrer-protected images failed to save while Open Image worked. A small W3C Referrer-Policy function (new browser-agent/referrer.ts, with the existing menu referrer helpers moved there) computes the header Electron's downloadURL maps into Chromium's download referrer: no-referrer, origin-only cross-origin by default, none on an https→http downgrade, credentials and fragment stripped, oversize → origin
  • Sign-in: the passkey hint waits for the pending-sign-in query to resolve instead of reading "loading" as "no handoff"; continuablePage refuses URLs carrying credentials, matching the shell's isSafeExternalUrl; the notice's TSDoc no longer claims one line (it wraps on purpose)
  • People: a profile whose manager is suspended shows "Manager is suspended." instead of "No manager recorded."

Type of Change

  • Bug fix

Testing

  • downloads.test.ts, in-flight-work.test.ts, updater.test.ts, terminal/service.test.ts, new terminal/process-group.test.ts (real exited pid → idle), new browser-agent/referrer.test.ts, sign-in-hosts.test.ts — new cases red on the pre-fix code
  • e2e/browser-page-parity.spec.ts: the image fixture now refuses requests without a Referer and records it; Save Image asserts the full page URL was sent (fails with the bare downloadURL)
  • desktop tsc --noEmit, targeted apps/sim type-check, biome; full gate in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ked terminals before an update restart, send the page referrer on Save Image, and tighten sign-in and people edge cases
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 1, 2026 5:32am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR strengthens desktop restart warnings and fixes image saves, sign-in hints, and manager status text.

  • Update prompts count downloads and terminals that may still be busy.
  • The app saves cleared relaunch routes before opening windows.
  • Save Image sends the page referrer allowed by its policy.
  • The browser sign-in hint waits for the handoff check and skips URLs with credentials.
  • The people page distinguishes a suspended manager from no manager.

Reviews (1) · Last reviewed commit: "fix(desktop): address release review — c..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 22 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit aa60ac2 into staging Nov 1, 2026
75 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/release-review-comment-fixes branch November 1, 2026 05:46

This branch was previously deployed

1 inactive deployment
Preview — eee4a69e Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant