Repository navigation
Conversation
Drop the rounded scrim behind the attribution label and keep the luminance-based text colour with a soft shadow for legibility. Assisted-by: Claude Code:claude-sonnet-5-5 AI-Scope: Wrote the CSS change and removed the comment that described the scrim, tested on hardware by the author.
Gtk.Overlay places a child in its own size_allocate, which a child's queue_allocate() with an unchanged size does not re-run. Queue the overlay too so a live position change takes effect at once. Assisted-by: Claude Code:claude-sonnet-5-5 AI-Scope: Root-caused the frozen label and wrote the one-line fix, confirmed on hardware by the author.
A long title and author line could run under the dock or the panel controls. Wrap it to two lines, ellipsize past that, and justify it toward the side of the active corner. Assisted-by: Claude Code:claude-sonnet-5-5 AI-Scope: Found the overlap on a long wallpaper title and wrote the wrapping and justification, checked on hardware by the author.
Contributor
Author
|
@mirkobrombin for review when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #30. Three commits, all on the attribution label:
wallpaper-attribution-positiondid not move the label until the next wallpaper change.Gtk.Overlayplaces children in its own size_allocate, whichqueue_allocate()on the label does not re-run when only the alignment changed. The overlay is queued too.Before: with the setting changed in Settings the label stayed in the old corner; a long title ran under the dock.
After: the label moves at once and wraps. Checked on hardware in our desktop build, which has carried these changes since 2026-09-21.
Build and tests on Debian forky:
ninjabuilds;meson test81 of 84 pass.parental-helperandcrash-handlerneed a real user and fail the same way on main;spell-integrationaborts in the container (no enchant ordering file) and is outside this change.AI assistance: disclosed