Repository navigation
Conversation
kb_keymap() unreferenced the old xkb_state but left the pointer set, so if the new keymap failed to compile, kb_key() kept using freed memory. Clear it first. Each keymap failure path also returned silently, which left a lock that drew normally but dropped every key; log the reason, and show "Keyboard unavailable" when a key arrives without a keymap. Assisted-by: Claude Code:claude-opus-5-5 AI-Scope: cleared the stale xkb_state, added failure logging in kb_keymap and the unavailable status in kb_key in lock_main.c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kb_keymap() unreferenced the old xkb_state but left the pointer set, so a keymap that failed to compile left kb_key() using freed memory. It now clears it, logs each keymap failure, and shows "Keyboard unavailable" when a key arrives without a keymap instead of silently dropping it.
Generative AI assistance
AI assistance: disclosed