Repository navigation
refactor: remove unused ProjectID function - #715
Merged
Merged
Conversation
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=======================================
Coverage 78.09% 78.10%
=======================================
Files 238 238
Lines 18106 18101 -5
=======================================
- Hits 14140 14137 -3
+ Misses 3966 3964 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mwbrooks
commented
Oct 23, 2026
Comment on lines
-82
to
-92
| // ProjectID returns the project ID associated with `ctx`, or | ||
| // `""` and `slackerror.ErrContextValueNotFound` if no project ID could be found. | ||
| func ProjectID(ctx context.Context) (string, error) { | ||
| var projectID, ok = ctx.Value(contextKeyProjectID).(string) | ||
| if !ok || projectID == "" { | ||
| return "", slackerror.New(slackerror.ErrContextValueNotFound). | ||
| WithMessage("The value for Project ID could not be found") | ||
| } | ||
| return projectID, nil | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
note: Kinda amazed we don't use the ProjectID anywhere. 🤷🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal cleanup with no user-facing changes.
Summary
This pull request removes
ProjectIDfrominternal/slackcontext/slackcontext.gofor maintainers, because the Godeadcodetool reports it as unreachable. Less unused code to read and keep compiling.ProjectIDfrominternal/slackcontext/slackcontext.gointernal/slackcontext/slackcontext_test.goTesting
go run golang.org/x/tools/cmd/deadcode@latest ./... | grep ProjectIDand confirm there's no outputgo build ./... && go test ./...and confirm both passRequirements