Repository navigation
feat: report actual component removals in the Markdown fidelity checker - #4316
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dev-dist
approved these changes
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some JSX components disappear from agent-facing exports without a clear signal. This PR records actual component removals during conversion and reports them through the existing Markdown fidelity checker, which now also verifies the final TXT output and has fewer false positives.
Changes
transformMarkdownaccepts an optionalonDropComponentobserver, passed throughbuildMarkdownArtifactandrenderLlmsPageMarkdown. Events are delivered only after a successful transformation, and the observer cannot change the output.unsupportednow means a JSX subtree was actually removed. Gaps in static source expectations are reported asunverifiable.DocCards/DocCard,MethodTabs, inlineCopyText,em/i,a,img(compared by URL and alt text), and tab slots written on one line.FeedPageisunverifiable(its export is a placeholder)./ccip/..., not/ccip/v2/...).PolicyInstanceBuilder(interactive tool; equivalent information exists elsewhere).--path) list detailed findings. CI warnings and job summaries list only new findings; CI stays non-blocking.Baseline and commands
The baseline is fully regenerated: 21,129 stale identities → 1,195 known findings. It records known debt, not approved losses.
--update-baseline: regenerates the baseline from a complete run, excluding exceptions; refuses if a page check fails.--omit-present: omits successful evidence from the JSON report (CI artifact ~127 MB → ~0.9 MB).--publish: writes the public component inventory; a failed run keeps the previous file.Reproduce the baseline:
npm run check:markdown-fidelity -- --update-baseline --omit-presentPublic report and CI
/reports/component-coverage.jsonuses schemaVersion 2. Refresh it weekly withnpm run report:markdown-fidelityfrom up-to-datemain, in a dedicated PR containing only that file. The Vercel build is unchanged and no TXT bundle is rewritten. The CI filter also runs validation on conversion dependency updates (MDX, remark, unified).Validation
missing3,073 → 480,unverifiable1,213 → 598 compared with the checker onmain. The 117 remainingunsupportedare real removals.Follow-ups
FeedList,StreamsNetworkAddressesTable), landing-page navigation (ToolsUtilitiesGrid,LayoutHero,TabGrid),ReportSchemaTabs,ChangelogSnippet, the interactive Remix tutorial steps (CCIP), and interactive tools to record as exceptions.unverifiable.