Skip to content

fix(sio-client): export acknowledgement decorator for declaration emit - #5577

Open
ascebiswajit wants to merge 2 commits into
socketio:mainfrom
ascebiswajit:fix/client-public-acknowledgement-types
Open

ascebiswajit wants to merge 2 commits into
socketio:mainfrom
ascebiswajit:fix/client-public-acknowledgement-types

Conversation

@ascebiswajit

@ascebiswajit ascebiswajit commented Oct 15, 2026 •

Copy link
Copy Markdown

Current behavior

Exporting a mapped type of a Socket’s public properties fails during TypeScript declaration generation with TS2883 because DecorateAcknowledgements is not exported from the package entry point.

Related to the remaining error reported in #5307.

New behavior

  • Export DecorateAcknowledgements from socket.io-client.
  • Add a mapped-type regression example.
  • Enable declaration generation in the existing public-exports example.
  • Run the declaration check in client CI.

Runtime behavior is unchanged.

Validation

  • Regression check fails before the fix and passes afterward.
  • Compilation and formatting pass.
  • All 112 Node tests pass locally and in the fork’s CI.
  • Browser tests could not start: the fork lacks Sauce Labs credentials, and EdgeDriver version resolution also failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant