Repository navigation
Keep brackets around IPv6 addresses in Endpoint#authority - #255
Open
andrewfader wants to merge 1 commit into
Open
andrewfader wants to merge 1 commit into
andrewfader wants to merge 1 commit into
Conversation
andrewfader
marked this pull request as ready for review
October 22, 2026 08:35
Signed-off-by: Andrew Fader <fader@yagni.co>
andrewfader
force-pushed
the
ipv6-authority
branch
from
October 23, 2026 03:06
22b2e7f to
fa84a92
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint#authorityusedURI#hostname, which strips IPv6 brackets. A request tohttp://[::1]:8080sentHost: ::1:8080.This uses
URI#hostinstead. Hostnames and IPv4 are unchanged. Tests added.