Repository navigation
Close a partially read request body once the response has been sent - #41
Open
andrewfader wants to merge 1 commit into
Open
andrewfader wants to merge 1 commit into
andrewfader wants to merge 1 commit into
Conversation
andrewfader
marked this pull request as ready for review
October 23, 2026 07:49
andrewfader
marked this pull request as draft
October 23, 2026 07:55
Signed-off-by: Andrew Fader <fader@yagni.co> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andrewfader
force-pushed
the
close-partially-read-input
branch
from
October 23, 2026 08:21
b867a21 to
b20c644
Compare
andrewfader
changed the title
andrewfader
marked this pull request as ready for review
October 23, 2026 08:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rack.inputis only closed when a read reaches the end of it. When an application reads part of the request body and then responds (for example, rejecting an upload, or a multipart parse error), the partially read body is never released, and async-http's HTTP/1 server waits for it indefinitely.This closes a partially read request body when the response body completes, or right away if there is no response body or the application raises. A body the application never read is left alone, so the server can still discard it and keep the connection alive. Tests added.