Repository navigation
Conversation
added 17 commits
October 26, 2026 12:42
…ve-enriched-html into @relextm19/scroll-position
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new fullscreen row invalidates existing screenshot baselines, and scroll events have cross-platform throttling, unit, and precision errors.
6 open issues
Regenerate fullscreen screenshot baselines after layout changes · New Use inclusive scroll throttle interval comparisons · New Convert native scroll pixels to density-independent coordinates · New Preserve fractional scroll coordinates in native event payloads · New Treat zero scroll throttle as no throttling on web · New Emit the latest scroll offset with trailing throttle delivery · New
Review effort: Balanced
Comment on lines
+118
to
+120
| <Text testID="scroll-offset-output" style={styles.scrollOffsetOutput}> | ||
| Scroll offset: {scrollOffset.toFixed(2)} | ||
| </Text> |
| super.onScrollChanged(horiz, vert, oldHoriz, oldVert) | ||
|
|
||
| val now = SystemClock.uptimeMillis() | ||
| if (now - scrollLastTick > scrollEventThrottle) { |
Comment on lines
+351
to
+352
| horiz, | ||
| vert, |
Comment on lines
+323
to
+324
| x: CodegenTypes.Int32; | ||
| y: CodegenTypes.Int32; |
Comment on lines
+204
to
+207
| if ( | ||
| !shouldEmitScrollEvent(scrollLastTickRef.current, scrollEventThrottle) | ||
| ) { | ||
| return; |
relextm19
marked this pull request as draft
October 29, 2026 19:32
relextm19
force-pushed
the
@relextm19/scroll-position
branch
from
October 30, 2026 11:33
e7a6c07 to
2e5d181
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Closes #169
Add onScroll event to
EnrichedTextInputtriggered when the content is scrolled. Payload is the same as in the React Native implementationAlso adds a
scrollEventThrottleprop defaulting to 16Test Plan
Check the metro logs when running the mobile example or browser logs when running the web test. You can also write your own handler for onScroll and test it yourself
Screenshots / Videos
Compatibility
Checklist