Repository navigation
Initial commit for Review - #1
Merged
Merged
Conversation
gigapod
reviewed
Sep 30, 2026
| sfTkError_t sfDevBMI330::begin(sfTkIBus *theBus) | ||
| { | ||
| // Adopt the supplied bus if one was given; otherwise keep whatever a prior call set. | ||
| if (theBus != nullptr) |
Member
There was a problem hiding this comment.
Just return if the bus is null. If not, then set the comm bus. No need for two if()s
|
|
||
| // How many dummy bytes precede read data is a property of the interface, not the register, so | ||
| // settle it once here rather than testing the bus type on every read. | ||
| if (_theBus != nullptr && _theBus->type() == ksfTkBusTypeSPI) |
Member
There was a problem hiding this comment.
style - I'd just make this an inline if.
_dummyBytes = (_theBus != nullptr && _theBus->type() == ksfTkBusTypeSPI) ? kDummyBytesSPI : kDummyBytesI2C.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.