Repository navigation
chore: merge develop into main - #468
Merged
Merged
Conversation
## Why `StanzaObservabilityRecorder` previously called OpenTelemetry `force_flush()` on the modular input’s thread. A slow or unavailable OTLP collector could therefore delay TA processing whenever the recorder exited its `with` block. ## What changed - Schedule explicit metric flushes on one daemon worker per observability service. Repeated requests are coalesced. - Replace OpenTelemetry’s synchronous exit hook for solnlib-created providers with one process-wide shutdown handler and a shared five-second grace period. - Drain a pending flush before shutdown, including when periodic export is disabled. Periodic export remains unchanged. ## Compatibility and trade-offs The public `flush()` signatures are unchanged, but returning now means the export was *scheduled*, not completed. `timeout_millis` limits the background attempt; it is not a caller-side wait. The last metrics may be lost if the exit grace period expires. Fork handling remains limited: the child gets a new worker, but an OTel provider inherited during an in-flight export may retain a locked reader. Recreating the provider after `fork()` is outside this PR. ## Testing - 173 observability tests passed on Python 3.9.19. - Tests cover blocked exports, request coalescing, the shared exit deadline, pending flush at shutdown, and a fork smoke test. - Python 3.13 runtime validation remains for CI.
wtobis-splunk
requested review from
pdzien-splunk,
sgoral-splunk and
vosmolovskiy-splunk
October 21, 2026 12:56
# [8.2.0-beta.1](v8.1.1...v8.2.0-beta.1) (2026-10-21) ### Bug Fixes * ADDON-91243 change telemetry flush to async ([#467](#467)) ([3e538df](3e538df)) * drain pending metric flush before shutdown ([4555232](4555232)) * harden async observability lifecycle ([9b3a2a5](9b3a2a5)) ### Features * add async metric flush worker ([5326914](5326914)) * bound metric shutdown across services ([280fba9](280fba9)) * make solnlib observability flush nonblocking ([c6897eb](c6897eb))
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
vosmolovskiy-splunk
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.