Skip to content

chore(vendor): the box's flow hero prints a size, never a raw minus - #113

Open
frahlg wants to merge 2 commits into
mainfrom
hero-no-minus
Open

frahlg wants to merge 2 commits into
mainfrom
hero-no-minus

Conversation

@frahlg

@frahlg frahlg commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Paired with srcfl/ftw#1862, which removes raw minus signs from the box page. The box's <ftw-energy-flow> printed a discharging battery as "−1.20 kW". It now prints "1.20 kW" with "discharging" under it, and still sums the signed value when it folds several packs.

This copies src/vendor/ftw/ftw-energy-flow.js byte for byte from the box branch (stamped b4d2488d) and re-records src/vendor/ftw/digests.json. The web app no longer draws this component on Now, because it draws the ring (#110). The copy stays in step so the vendored check holds.

Merge together with srcfl/ftw#1862. If that branch changes before merge, take the copy again.

Contract-pair: srcfl/ftw@cd68b44

Evidence: npm run verify passes, with svelte-check at 0 errors and 1178 tests plus 48 stats tests passing. tests/vendored.test.ts failed before the re-record and passes after it. No token drift against the box branch.

🤖 Generated with Claude Code

Copied again from srcfl/ftw web/components/ftw-energy-flow.js at
b4d2488d41ff046356a6710b1d173e38cdc96a64 (srcfl/ftw#1862). fmtKw prints
the size of a power; the word under the bubble, such as "discharging",
says the direction. The signed kW the component sums is unchanged.

The provenance line is stamped with that commit and the digest is
re-recorded with RECORD_VENDOR_DIGESTS=1, as tests/vendored.test.ts asks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T07:18:33.568262Z 0a80d02 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ftw-webapp 0a80d02 Commit Preview URL

Branch Preview URL
Oct 26 2026, 07:16 AM

@frahlg
frahlg marked this pull request as draft October 26, 2026 06:53
The box's second review round: Home use in the middle keeps its sign,
the planets keep printing sizes, and a battery FTW only observes says so
under its title while the line under its size keeps the direction.
Copied byte for byte; digests re-recorded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frahlg
frahlg marked this pull request as ready for review October 26, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant