Repository navigation
fix(control): ship SOC ceilings and Charge restart recovery - #1870
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Battery charging must stop at the owner's configured SOC maximum, and a manual Charge override must end when Core restarts.
This brings the approved fixes from #1867 and #1869 onto master for the requested beta. Both were merged into
fix/fuse-one-function; #1789 remains a separate draft. The SOC ceiling is adapted to master's existing safety pipeline and wired at both startup and config reload. Its fuse-relief test uses a fresh meter reading so the older smoothed-meter path sees the intended overage.Behavior:
soc_maxoverrides the planner's ceiling. All EMS modes, temporary holds and self-tuning honor it, with a one percentage point resume gap.Validation: the SOC, restart, MQTT and fresh-start planning regression tests pass on this master-based branch. Full
make verifypassed on 4742c9e (Go suites, vet, build, protocol boundaries and packaging checks). Docker context and Avahi runtime checks skipped because Docker is unavailable. The first local pass used the pre-adaptation fuse test fixture and failed; the corrected fixture and full final pass are clean. No site deployment or hardware test.