Repository navigation
test(site): the runner plans again before each job, recent PRs first - #1927
Merged
Merged
Conversation
The runner planned once and then ran the whole list. A list of ten PRs takes three hours, so it tested heads that had moved on, and a second runner ran the same commits again. Now it plans before each job, so a commit another runner has marked pending is skipped and a moved PR runs at its new head. Pull requests run in number order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Number order put weeks-old PRs ahead of the work in review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
siterig-runnerplanned once per tick and then ran the whole list. A short run takes 18–28 minutes, so a list of ten PRs takes three hours or more. In that time:Change
tickplans again before each job and runs the first job it has not run in this tick. A commit that another runner has marked pending is skipped, and a moved PR runs at its new head.nextkeeps a job from running twice in one tick when its status fails to post.plansorts pull requests byupdated_at, most recent first. That is the work in review; a PR untouched for weeks can wait. (Number order, tried first, put weeks-old PRs ahead of it.) Master still comes first and the nightly seeds last.Two runners can still pick the same job if they plan within the same few seconds, before either posts pending. That window is seconds wide, not hours.
Tests
go test ./go/test/site/runner/passes. The newTestPlanTakesRecentPullFirstAndNextSkipsWhatRancovers the order and the skip.Test tooling only, so no changeset.
🤖 Generated with Claude Code