Skip to content

test(site): the runner plans again before each job, recent PRs first - #1927

Merged
frahlg merged 2 commits into
masterfrom
runner-replan-each-job
Oct 28, 2026
Merged

frahlg merged 2 commits into
masterfrom
runner-replan-each-job

Conversation

@frahlg

@frahlg frahlg commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Problem

siterig-runner planned once per tick and then ran the whole list. A short run takes 18–28 minutes, so a list of ten PRs takes three hours or more. In that time:

Change

  • tick plans again before each job and runs the first job it has not run in this tick. A commit that another runner has marked pending is skipped, and a moved PR runs at its new head.
  • next keeps a job from running twice in one tick when its status fails to post.
  • plan sorts pull requests by updated_at, most recent first. That is the work in review; a PR untouched for weeks can wait. (Number order, tried first, put weeks-old PRs ahead of it.) Master still comes first and the nightly seeds last.

Two runners can still pick the same job if they plan within the same few seconds, before either posts pending. That window is seconds wide, not hours.

Tests

go test ./go/test/site/runner/ passes. The new TestPlanTakesRecentPullFirstAndNextSkipsWhatRan covers the order and the skip.

Test tooling only, so no changeset.

🤖 Generated with Claude Code

The runner planned once and then ran the whole list. A list of ten PRs
takes three hours, so it tested heads that had moved on, and a second
runner ran the same commits again. Now it plans before each job, so a
commit another runner has marked pending is skipped and a moved PR runs
at its new head. Pull requests run in number order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frahlg frahlg added the no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping) label Oct 28, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T00:32:39.876161Z 811f440 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Number order put weeks-old PRs ahead of the work in review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frahlg frahlg changed the title test(site): the runner plans again before each job, oldest PR first test(site): the runner plans again before each job, recent PRs first Oct 28, 2026
@frahlg
frahlg merged commit e42a923 into master Oct 28, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant