Skip to content

docs: remove wrong comment on postgresql credentials secret - #882

Merged
xeniape merged 1 commit into
mainfrom
docs/remove-secret-example-comment
Oct 19, 2026
Merged

xeniape merged 1 commit into
mainfrom
docs/remove-secret-example-comment

Conversation

@xeniape

@xeniape xeniape commented Oct 19, 2026

Copy link
Copy Markdown
Member

Description

Small docs fix. Secret says it's only necessary when using Celery, which is wrong.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 19, 2026
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 19, 2026

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 19, 2026
@xeniape
xeniape added this pull request to the merge queue Oct 19, 2026
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Oct 19, 2026
Merged via the queue into main with commit 5f65191 Oct 19, 2026
11 checks passed
@xeniape
xeniape deleted the docs/remove-secret-example-comment branch October 19, 2026 11:55
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants