Skip to content

feat(dns): Onboard move-zone commands - #1706

Merged
Fyusel merged 1 commit into
mainfrom
onboard-zone-move-commands
Oct 29, 2026
Merged

Fyusel merged 1 commit into
mainfrom
onboard-zone-move-commands

Conversation

@Fyusel

@Fyusel Fyusel commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

STACKITCLI-41

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel
Fyusel requested a review from a team as a code owner October 28, 2026 06:19
@Fyusel
Fyusel force-pushed the onboard-zone-move-commands branch from bdbd0b9 to 201f83e Compare October 28, 2026 06:19
Comment thread internal/cmd/dns/zone/generate-move-code/generate_move_code.go
Comment thread internal/cmd/dns/zone/move/move.go Outdated
Comment thread internal/cmd/dns/zone/move/move.go Outdated
@Fyusel
Fyusel force-pushed the onboard-zone-move-commands branch 2 times, most recently from f6eb958 to 01b3089 Compare October 28, 2026 11:08
Comment thread internal/cmd/dns/zone/move/move.go
Comment thread internal/cmd/dns/zone/move/move.go Outdated
@SerseusWasTaken
SerseusWasTaken force-pushed the onboard-zone-move-commands branch from 01b3089 to 8d16dc5 Compare October 28, 2026 13:55
@Fyusel
Fyusel force-pushed the onboard-zone-move-commands branch from 8d16dc5 to ada03a0 Compare October 29, 2026 06:58
@Fyusel
Fyusel force-pushed the onboard-zone-move-commands branch from 989641d to 73592b5 Compare October 29, 2026 07:02
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/delete-move-code 44.44% (+44.44%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/generate-move-code 55.56% (+55.56%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/move 49.15% (+49.15%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/validate-move-code 66.67% (+66.67%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/dns/utils 87.88% (+3.88%) 👍
Coverage details

Compared to commit 27e6536 (run #40733813858)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/delete-move-code/delete_move_code.go 44.44% (+44.44%) 36 (+36) 16 (+16) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/generate-move-code/generate_move_code.go 55.56% (+55.56%) 45 (+45) 25 (+25) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/move/move.go 49.15% (+49.15%) 59 (+59) 29 (+29) 30 (+30) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/validate-move-code/validate_move_code.go 66.67% (+66.67%) 39 (+39) 26 (+26) 13 (+13) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/zone.go 0.00% (ø) 13 (+4) 0 13 (+4)
github.com/stackitcloud/stackit-cli/internal/pkg/services/dns/utils/utils.go 87.88% (+3.88%) 33 (+8) 29 (+8) 4 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/delete-move-code/delete_move_code_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/generate-move-code/generate_move_code_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/move/move_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/dns/zone/validate-move-code/validate_move_code_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/dns/utils/utils_test.go

@Fyusel
Fyusel merged commit a82a0e0 into main Oct 29, 2026
5 checks passed
@Fyusel
Fyusel deleted the onboard-zone-move-commands branch October 29, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants