Repository navigation
Generator: Update SDK /services/dns - #13088
Closed
stackit-pipeline wants to merge 1 commit into
Closed
stackit-pipeline wants to merge 1 commit into
stackit-pipeline wants to merge 1 commit into
Conversation
gorelease reportgenerated on Thu Oct 22 12:18:53 UTC 2026
|
Fyusel
requested changes
Oct 23, 2026
| @param ctx context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background(). | ||
| @return ApiDnslookupRequest | ||
| */ | ||
| Dnslookup(ctx context.Context) ApiDnslookupRequest |
Contributor
There was a problem hiding this comment.
The pattern which is used by us in the SDK is: [Action][Resource]
So this should be named e.g. LookupDNS or LookupDomain (what fits better for you)
Contributor
There was a problem hiding this comment.
The same for the other ones as well.
LookupDNSPayload / LookupDomainPayload
|
|
||
| // DnslookupExecute executes the request | ||
| // @return DnslookupLookupResponse | ||
| DnslookupExecute(r ApiDnslookupRequest) (*DnslookupLookupResponse, error) |
Contributor
There was a problem hiding this comment.
DnslookupLookupResponse is doubled -> LookupDNSResponse
| @param ctx context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background(). | ||
| @return ApiFlushRequest | ||
| */ | ||
| Flush(ctx context.Context) ApiFlushRequest |
|
|
||
| // FlushExecute executes the request | ||
| // @return FlushCreateFlushResponse | ||
| FlushExecute(r ApiFlushRequest) (*FlushCreateFlushResponse, error) |
Contributor
There was a problem hiding this comment.
FlushCreateFlushResponse -> FlushCacheResponse ?
Contributor
|
superseded by #13128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from GitHub run 39776614802
spec comparison: stackitcloud/stackit-api-specifications@0afa5e4...3f5d093