Repository navigation
Upgrade vendored GoogleTest to 1.18.0 - #3475
Draft
SteveBronder wants to merge 1 commit into
Draft
SteveBronder wants to merge 1 commit into
SteveBronder wants to merge 1 commit into
Conversation
Replace the GoogleTest nested under Google Benchmark 1.5.1 with the pinned v1.18.0 release. Preserve Stan MPI initialization and the existing library paths. Pin the maintenance script to the same release and verify its license copy against the release. Remove the temporary CMake policy-minimum wrapper now that GoogleTest declares CMake 3.16 and C++17, matching the project setup.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the GoogleTest nested in
lib/benchmark_1.5.1to v1.18.0, preserving Stan's MPI initialization and the existing dependency paths. Pin the maintenance script to that release, verify the license copy, and remove the temporary CMake policy override; the release declares CMake 3.16 and C++17.This draft is stacked on #3463 with
cmake-mathas its base so the dependency upgrade stays separate from the CI repairs. Retarget and rebase ontodevelopafter #3463 merges.Validation:
The full native CI compiler matrix must pass before merging.