Skip to content

DupFileManager: harden detached process spawn with start_new_session #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phildapunk wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

DupFileManager: harden detached process spawn with start_new_session #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/DupFileManager/DupFileManager.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: DupFileManager
description: Manages duplicate files.
version: 1.0.2
version: 1.0.3
url: https://discourse.stashapp.cc/t/dupfilemanager/1331
ui:
javascript:
Expand Down
5 changes: 4 additions & 1 deletion plugins/DupFileManager/StashPluginHelper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,12 @@ def executeProcess(self, args, ExecDetach=False):
if self.IS_LINUX:
args = ["nohup"] + args
self.Trace(f"Executing detached process using Popen({args})")
# start_new_session puts the child in its own session, so it survives the
# parent task process exiting (needed on macOS; harmless on Linux too).
pid = subprocess.Popen(args, start_new_session=True).pid
else:
self.Trace(f"Executing process using normal Popen({args})")
pid = subprocess.Popen(args).pid # On detach, may need the following for MAC OS subprocess.Popen(args, shell=True, start_new_session=True)
pid = subprocess.Popen(args).pid
self.Trace(f"pid={pid}")
return pid

Expand Down
Loading