Repository navigation
test(@stdlib/fft/base/fftpack/float32/sinqi): fix factorization reads - #16292
Draft
Planeshifter wants to merge 1 commit into
Draft
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
The scheduled `linux_test` workflow failed on develop with four assertion failures in the "stride and offset" test of `fft/base/fftpack/float32/sinqi` (e.g., expected `8`, actual `1.1210387714598537e-44`). Root cause: `rffti1` stores the integer factorization data (sequence length, number of factors, and factors) through a `Uint32Array` view over the `Float32Array` workspace, so reading those slots as floats yields denormals. This commit reads the factorization section through a `Uint32Array` view, consistent with the `cosqi` and `rffti` tests. Ref: https://github.com/stdlib-js/stdlib/actions/runs/39753951313 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CrVhRwPsPFuqS8JdR5SEeJ
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
fft/base/fftpack/float32/sinqi, which fails in the scheduledlinux_testworkflow (run: https://github.com/stdlib-js/stdlib/actions/runs/39753951313).Symptom: four assertions fail (e.g., expected
8, actual1.1210387714598537e-44).Root cause:
rffti1stores the integer factorization data through aUint32Arrayview over theFloat32Arrayworkspace. The test read those slots as floats, which yields denormals. The test now reads the section through aUint32Arrayview, as thecosqiandrfftitests do.Validation: the test file passes locally (12024 passing, 0 failing; 4 failing before the change). Three independent reviews approved; the one style note (
max-lenpragma) is addressed.Related Issues
None.
Questions
No.
Other
Reviewer notes: the
sinqiREADME,lib/main.js,lib/index.js,docs/types/index.d.ts,docs/repl.txt, andexamples/index.jshave the same mistake (factors shown as<Float32Array>[ 8, 2, 2, 4 ]/ read as floats).cosqialready uses theUint32Arrayform. Left out of this PR to keep it to the failing test; follow-up.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by Claude Code running as an automated CI-triage routine: it diagnosed the failing job from the workflow logs, authored the fix, and had it reviewed by separate AI reviewers. No human has reviewed it yet.
@stdlib-js/reviewers
Generated by Claude Code