Repository navigation
test: Shrink the example triangle to demonstrate the rendering comparison - #3
Closed
stephanmeesters wants to merge 2 commits into
Closed
stephanmeesters wants to merge 2 commits into
stephanmeesters wants to merge 2 commits into
Conversation
stephanmeesters
force-pushed
the
demo/rendering-triangle-shrink
branch
from
October 25, 2026 12:21
1e60c90 to
388b087
Compare
…ompare them with the base commit Add a RenderingTest fixture that creates a real D3D8 device with an offscreen render target once for all rendering tests, and restores the default device state before each test. Its helpers clear the target, draw colored triangles, and capture the target as a PNG image with its pixels for checks. Each test lives in a file of its own; the temporary Clear and Triangle examples show how to write them. The CTest step of CI skips the RenderingTest suite; instead the plain win32 build uploads the Google Test executables and the new Rendering Check jobs in GenCI run them on a Windows runner under DXVK and Mesa lavapipe. The DXVK, Mesa and Vulkan loader downloads are pinned, so the rendering does not change with the runner image. The rendering check also runs the tests of the base commit, downloaded from its earlier GenCI run, under the same DXVK and Mesa. The base is the previous main commit for a push and the merge base with main otherwise, falling back to the nearest ancestor with a package. The check compares the PNG files and uploads one unzipped HTML page with the base, new and difference images inline, which opens in the browser. The message of the check and the job summary link to it. A changed or missing image fails the check of a pull request, so reviewers look at the report; on main it is a warning, because main becomes the base of later changes. No reference images are stored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ison The triangle keeps its centroid, so the test still passes while its image changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stephanmeesters
force-pushed
the
demo/rendering-triangle-shrink
branch
from
October 25, 2026 13:14
388b087 to
6c0447c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo PR on the fork, not for merging. It shrinks the example triangle around its centroid, so the Triangle test still passes but triangle.png changes. The Rendering Check should report it as changed compared with the main commit and show the difference in the report.
🤖 Generated with Claude Code