Repository navigation
fix(sidebar): one tree rail for both child kinds - #491
Open
theogravity wants to merge 1 commit into
Open
theogravity wants to merge 1 commit into
theogravity wants to merge 1 commit into
Conversation
Harness subagent rows hung off their own ml-4 rail with per-row rail spans and long elbows, while helper-subshell children used the section's ml-5 border-l with short connector ticks. A pane that reports both drew two rails and mismatched indents. Render the roster rows with the section's geometry, and match the child row's pl-3 and column gap so dots and names share one x.
Contributor
Author
|
Code review round 1: zero MAJOR, zero MINOR. Two NITs left open on purpose: the 2px rail seam at the helpers-to-roster junction is in family with the existing breaks between tree sections, and the switch-error line riding the rail only exists on the failed-switch path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A pane that has both created helper subshells and reported harness subagents drew two tree rails. The helper rows hung off the section's
ml-5 border-lwith short connector ticks, while the roster rows carried their ownml-4line, per-row rail spans, long elbows, and a different content indent. Mixed lists read as two trees bolted together (Theo's screenshot).Fix
HarnessSubagentRowsnow renders with the exact geometry the helper-subshell section uses:ml-5 border-l pl-2container plus abefore:-left-2 before:w-2tick per row. The row button padspl-3and the dot-to-name gap isgap-x-2, matching the child row's link, so status dots and names share one x across both kinds.Measured on a live stack: before, rails sat at 28 vs 32 with 12px vs 8px elbows and dots 8px apart; after, rails, elbows, dots, and names are pixel-identical.
Verification
bun run test:changed -- --unit: 3194 pass (server-web)bun run verify:changed: all affected builds/type checks, e2e 97 passed / 5 skippedbun run lint:design: clean