Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed with no findings. Reading the full diff and surrounding handler, permissions, runtime layers, and tests revealed no concrete issues. Linked advisors bypass database connection resolution while preserving token validation and cache finalization.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
parallel
db advisors --remoteruns no longer break each other with28P01whats improved/fixed?
before calling the advisors API it set up a database login it never used
every setup resets the shared
cli_login_postgrespassword, so two runs at once (or one next to another remote db command) knocked each other out, and on a network without IPv6 one failed after about 150 show?
the remote path now skips the database and goes straight to the advisors API
this brings it in line with
db query --remotesince #7188, so both remote read commands work the same wayflowchart LR run["db advisors --remote"] run -->|before, no DB password| mint["new temp login role<br/>resets the shared password"] mint -- IPv6 --> api1["advisors API"] mint -- no IPv6 --> wait["pooler retries the login"] wait -- another run reset it --> fail["fails with 28P01"] wait -- no clash --> api1 run -- now --> ref["resolve project ref<br/>or branch"] ref --> token["check access token"] token -- missing --> login["asks to run supabase login"] token -- ok --> api2["advisors API<br/>security and/or performance"] api2 --> out["filter by --level<br/>print, exit by --fail-on"]ref:
BREAKING CHANGE:
db advisors --remoteno longer connects to the database first (matchesdb query --remote), so it no longer resolves database settings, creates a temporary login role or removes network bans under--yes