Repository navigation
test: show null password in PgBouncer regression output - #2593
Open
kankankanp wants to merge 1 commit into
Open
kankankanp wants to merge 1 commit into
kankankanp wants to merge 1 commit into
Conversation
Author
|
Hi @samrose, could you please approve the GitHub Actions workflow runs for this fork PR when convenient? They are currently awaiting maintainer approval. For context, #1567 added the pgbouncer.get_auth regression test, and this PR makes the NULL password visible in its output, as requested in #1568. Thank you for your time and consideration. |
Collaborator
|
@kankankanp I am no longer the maintainer of this repo. Those who are can review when they are ready to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A test-only change to make a
NULLpassword visible in the PgBouncer SQL regression output. Related to #1568.What is the current behavior?
The expired-user check calls
select pgbouncer.get_auth(...). That displays the function's two fields as one composite value:The empty password field is easy to miss. Setting
\pset nullalone does not change it, because psql sees the composite value as one non-null column.What is the new behavior?
The check uses
select * from pgbouncer.get_auth(...)to displayusernameandpasswordas separate columns, and sets\pset null '<null>'for the test:The SQL test and its matching expected output are updated together. The authentication function and the other checks are unchanged.
Additional context
NULLvalue explicit without changing what the test checks.psql -a -q -Xproduced the expected output for a row with a null password.nixbot/nix-evalandnixbot/nix-buildchecks passed. GitHub Actions workflows are awaiting maintainer approval for this fork PR and have not run yet. The full Nix regression suite was not run locally because Nix is not installed here.