Repository navigation
Clarifies data protection policies - #16
Open
rahulraj80 wants to merge 3 commits into
Open
rahulraj80 wants to merge 3 commits into
rahulraj80 wants to merge 3 commits into
Conversation
Adds internal/telemetry/contract: a byte-identical mirror of the observer telemetry contract v1.1.0 that the reporter server (observer_reporter / reporterd) pins. It adds the baseline tier and the prompt_cycle event, whose field allowlist admits only model, provider, sizes, cache percentage, end-to-end prompt-cycle time and a segment tag (user prompt / system nudge / tool call): no prompt or output text by construction, with a test that asserts it. No runtime behaviour changes: nothing in the binary emits or sends telemetry yet. `make verify-telemetry-contract` regenerates the golden artifacts with golden_gen.py and fails if they drift from the committed copies. Verified: go build ./...; go vet + go test ./internal/telemetry/...; make verify-telemetry-contract.
…bound every free-form string
v1.1.0 enforced its no-text-fields guarantee only for prompt_cycle: the other
nine events accepted any extra key, and app version/os/arch, prompt_cycle
span/turn_id, envelope client_version/os/arch and event session_span/
schema_version were unchecked strings. Every event now has a closed field
allow-list (EventFields; app_start/app_stop keep version, os, arch per the
plan §D5 taxonomy), free-form strings must be identifiers
(^[A-Za-z0-9._+-]{1,64}$), and schema_version must be RFC 3339. The golden
contract.json records fields + ident_pattern so the cross-repo drift gate pins
them; artifacts are byte-identical across observer_reporter,
superbased-observer-private and observer_planner.
Verified: go test ./internal/telemetry/..., make verify-telemetry-contract, golangci-lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linked issue
How was this tested?
make test(go test -race ./...)make lint(golangci-lint)Docs impact
Checklist
feat:,fix:,docs:,test:,chore:,refactor:,perf:)make lintis cleanany test fixtures
Need help on this PR? Tag
@codesmith-botwith what you need.