Repository navigation
Panels page: group cards by the menu that opens them - #1307
Merged
Merged
Conversation
Home comes first with the mouse panel, the keyboard and the menus Home opens, Tabs listed inside Browser; then My panels with the New panel button; then More actions with the three menus only it opens. Menus on both Home and More are listed once, under Home, and say Also on More. The browser fallback gains Browser, Tabs, More actions and Displays so the groups show without the backend. Closes #1306 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
My panels stays at the top as the page's main content. The built-in menus and panels become one row each in two lists, On Home and On More actions, side by side, with Tabs indented under Browser, instead of fifteen picture cards in three groups. Closing the editor puts focus back on the row or card that opened it, found by id. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The docs intro now describes the page as it is: the user's panels first, then Built-in menus and panels as two lists. Rows are called rows, the page of clicks after a point is named as the one that cannot change, the New panel button is the explicit focus fallback, and a nested menu whose parent is missing falls to Other menus instead of vanishing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1306
The Panels page listed eleven built-in menu cards in one flat row, with the mouse panel and keyboard in a separate section, so nothing showed which menu opens which, and the page was busy.
Now:
Editing, not changed, also on More;Tabs, not changed, in Browser); the lists are named by their headings and the nested list isInside Browser, so screen reader users get the same structure. Any menu kind the frontend does not know lands in an Other menus list rather than disappearing.The browser fallback in
api.tsgains Browser, Tabs, More actions and Displays so the lists show without the backend and in tests.Docs:
site/src/content/docs/using/panels.mddescribes the lists and the screenshot is recaptured.Validation
npm run lint,npm test(356 vitest + 23 node),npm run build,sitebuild: pass.lists the built-in menus and panels under the menu that opens them(order, nesting, focus return) andkeeps a menu it does not know where to place.npm run tauri dev) driven with Cua Driver: the Panels page shows the two lists with the rows named as above; opening Tabs and choosing All panels returns to the list.🤖 Generated with Claude Code