Repository navigation
An open page follows edits to its panel straight away - #1315
Merged
Merged
Conversation
Saving a panel, a rearranged menu or the mouse panel and keyboard extras rebuilds the page that is open in the scanner, scanning again from its top, and redraws it. A deleted panel gives way to the page under it, and the My panels list relists. Before, the open page kept its old tiles until it was reopened. Closes #1314 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Dev build check ( |
The mouse panel keeps a pause or an error pause across new extra tiles, as the keyboard does; an open menu keeps a wait for a switch; saving a document the open page is not built from, or saving it unchanged, leaves the scan where it is. The docs say where a deleted panel leaves you and that a pointer move is finished first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1314
Editing a panel while it was open in the scanner left the old tiles on screen until the page was reopened; the setters on the workflow said as much. Now
Workflow::refresh_pageruns afterset_panels,set_menu_overridesandset_panel_extras:set_extrason both), keeping its page; the keyboard keeps a pause.scanning_runtime::refresh_custom_panelsnow redraws on the main thread when the scan is active, so the change is visible without a switch press.Docs: the Panels page says a saved panel changes in the scanner there and then.
Validation
cargo fmt --check,cargo clippy --all-targets -D warnings,cargo test --lib(947): pass.sitebuild passes. No frontend changes.an_open_panel_follows_its_edit_and_leaves_when_deleted,an_open_menu_and_list_follow_their_edits,an_open_mouse_panel_follows_its_extra_tiles; two tests that encoded the old "until reopened" behaviour now assert the new one.🤖 Generated with Claude Code