Skip to content

An open page follows edits to its panel straight away - #1315

Merged
enaboapps merged 5 commits into
mainfrom
panel-refresh
Nov 3, 2026
Merged

enaboapps merged 5 commits into
mainfrom
panel-refresh

Conversation

@enaboapps

Copy link
Copy Markdown
Contributor

Closes #1314

Editing a panel while it was open in the scanner left the old tiles on screen until the page was reopened; the setters on the workflow said as much. Now Workflow::refresh_page runs after set_panels, set_menu_overrides and set_panel_extras:

  • An open custom panel is rebuilt from its saved document (same page, scanning again from the top). If it was deleted, the page gives way to the one under it, with no error.
  • An open built-in menu (Home or any rearrangeable menu) and the My panels list are rebuilt the same way, so a rename shows in the list at once.
  • An open mouse panel or keyboard takes the new extra rows and columns in place (set_extras on both), keeping its page; the keyboard keeps a pause.
  • A page in the middle of a move, scroll or radar is left alone until it is next opened.
  • scanning_runtime::refresh_custom_panels now redraws on the main thread when the scan is active, so the change is visible without a switch press.

Docs: the Panels page says a saved panel changes in the scanner there and then.

Validation

  • cargo fmt --check, cargo clippy --all-targets -D warnings, cargo test --lib (947): pass. site build passes. No frontend changes.
  • New tests: an_open_panel_follows_its_edit_and_leaves_when_deleted, an_open_menu_and_list_follow_their_edits, an_open_mouse_panel_follows_its_extra_tiles; two tests that encoded the old "until reopened" behaviour now assert the new one.
  • Dev build check with Cua Driver: see comment below.

🤖 Generated with Claude Code

Saving a panel, a rearranged menu or the mouse panel and keyboard extras
rebuilds the page that is open in the scanner, scanning again from its
top, and redraws it. A deleted panel gives way to the page under it, and
the My panels list relists. Before, the open page kept its old tiles
until it was reopened.

Closes #1314

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
site Ready Ready Preview Nov 3, 2026 12:10pm UTC

Request Review

@enaboapps

Copy link
Copy Markdown
Contributor Author

Dev build check (npm run tauri dev, driven with Cua Driver): made a starter panel, pressed Try it so it opened in the scanner (Keyboard, Mouse / Back, Close), brought the window back, relabelled the first tile "Typing" and pressed Save panel. The open panel in the scanner changed to Typing straight away, without a switch press, and the card on the Panels page matched.

The mouse panel keeps a pause or an error pause across new extra tiles,
as the keyboard does; an open menu keeps a wait for a switch; saving a
document the open page is not built from, or saving it unchanged,
leaves the scan where it is. The docs say where a deleted panel leaves
you and that a pointer move is finished first.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@enaboapps
enaboapps marked this pull request as ready for review November 3, 2026 12:09
@enaboapps
enaboapps merged commit 0050908 into main Nov 3, 2026
10 checks passed
@enaboapps
enaboapps deleted the panel-refresh branch November 3, 2026 12:45
@enaboapps enaboapps mentioned this pull request Nov 3, 2026

This branch was successfully deployed

1 active deployment
Preview — 12449ebe Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A panel open in the scanner does not show edits until it is reopened

2 participants