[ovitrif]

Twin: synonymdev/bitkit-ios#1130
Companion: synonymdev/bitkit-e2e-tests#285
Refs: synonymdev/blocktank-lsp-http#168

Description

• Ignores the two instrumented tests that create Blocktank orders or CJIT entries, because Blocktank staging now serves the read-only API: POST /channels and POST /cjit return 404.
  • BlocktankTest.testCreateCjitEntry
  • BlocktankTest.testOrders
• Read-only cases (testGetInfo, testOrderEstimate) and the regtest deposit/mine tests keep running.

Out of Scope

• Blocktank sunset UI: handled in feat: blocktank sunset #1696.
• E2E specs that buy channels: handled in test: stop buying blocktank channels in e2e specs bitkit-e2e-tests#285.

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

• updated BlocktankTest.kt — order and CJIT creation cases ignored

Evidence

• BlocktankTest runs only in the UI Tests workflow (push to master or dispatch); a dispatch on this branch is linked in a comment below.

Gaps

None.

Models used

• Planning/scoping: Claude Opus 5.5 (reasoning: low)
• Implementation: Claude Opus 5.5 (reasoning: low)
• Review: Not performed

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T16:09:11.130109Z	ac49b32	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

Regtest APK

Built from ac49b32 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

[greptile-apps]

Confidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Skips testCreateCjitEntry and testOrders with method-level @Ignore annotations and a reason referencing the Blocktank change.

• Blocktank integration runs skip the CJIT and order creation checks.

ovitrif explicitly intends to disable these two tests because staging no longer supports creation. The skipped creation coverage is the stated scope, not an unintended loss of coverage.

_{Reviews (1) · Last reviewed commit: "test: skip blocktank order and cjit crea..." · Reviewed by Greptile}

[talosmachina]

No findings. Puts @Ignore on the two BlocktankTest cases that create a Blocktank order or a CJIT entry, now that staging refuses those writes. Reviewed ac49b32, light tier. Reasoned from the code and CI, not built here.

What I checked, and 3 candidates I ruled out

Read in full: BlocktankTest.kt
Call sites traced: createCjit, createOrder and estimateFee across app/src/androidTest and app/src/test
CI: build, lint, detekt and the APK job are green. build-local and Greptile were still pending. BlocktankTest only runs in UI Tests (push to master or dispatch), so no PR check exercises this file.

Ruled out

• Another instrumented test still creates orders: createCjit is called only in testCreateCjitEntry. The createOrder hits in TransferViewModelTest.kt are against a mocked blocktankRepo, so they never reach staging.
• testOrderEstimate is also a write and fails the same way: it posts to the estimate endpoint, not to /channels. Against Env.blocktankApiUrl for regtest (https://api.stag0.blocktank.to/blocktank/api/v2) just now, GET /info and POST /channels/estimate-fee-full returned 200 and POST /channels returned 404, so the two cases left running are the ones staging still serves.
• Kotlin warnings break compilation (allWarningsAsErrors): @Ignore leaves the method bodies compiled and every import in use, so nothing becomes unused.

Merge confidence: 4/5, no findings, but the only workflow that runs BlocktankTest is the UI Tests dispatch the body links, and it is not a check on this PR.

Reviewer model: claude-opus-5-5
Reasoning effort: Not exposed (the review runner does not report a reasoning setting)

[ovitrif]

UI Tests on this branch: https://github.com/synonymdev/bitkit-android/actions/runs/40356197449

BlocktankTest passes: testGetInfo and testOrderEstimate run green, and the two order/CJIT cases are ignored.

The run still fails on five tests that make no Blocktank order. Each one also fails on master before the read-only switch:

• PreparedOnchainRecoveryFixtureTest.seedPreparedOriginalForRecoveryUi: OnchainTxCreationFailed; also failed in https://github.com/synonymdev/bitkit-android/actions/runs/39995511943 (23 Oct).
• UtxoSelectionTests.testUtxoSelection: final balance 120 000 instead of 170 000 after regtest deposits; also failed in https://github.com/synonymdev/bitkit-android/actions/runs/40317476547 (26 Oct, before the switch).
• TxBumpingTests.testBumpFeeByRbf: deposit balance 0 instead of 100 000. This is the same regtest deposit/sync timing as testUtxoSelection; TxBumpingTests also failed in https://github.com/synonymdev/bitkit-android/actions/runs/40343188729.
• ReceiveHardwareFlowTest.hardwareEditorReturnsToTrezorTab: Failed to inject touch input; failing since 23 Oct.
• UsdtBridgeDetailsTest.providerRefundShowsSourceNetworkAndLocalizedAmountAndHonorsEligibility: localized amount text not displayed; failing since 23 Oct.

UI Tests runs only on push to master and is not a check on this PR.