Skip to content

test: cover transfer to spending without blocktank channels - #284

Closed
ovitrif wants to merge 1 commit into
mainfrom
feat/stop-new-channels
Closed

ovitrif wants to merge 1 commit into
mainfrom
feat/stop-new-channels

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

Companion:

Updates the E2E suite for the app PRs that stop Bitkit from buying Blocktank channels. Transfer To Spending now opens a "Transfer Unavailable" sheet, Continue leads to a "Choose a Lightning provider" screen (third-party LSP links, Manual Setup, QR Code), and the Home "Spend" suggestion card is gone.

  • @transfer_1 now checks that Transfer To Spending opens the sheet, that Cancel closes it, and that Continue shows four providers with Manual Setup opening the manual connection fields. The Blocktank purchase cases (the old @transfer_1 and @transfer_max) are removed, since the app can no longer buy a channel.
  • @multi_address_2 opens its channel to the local LND node with all savings, through a new openChannelToLndFromSavings helper, instead of buying one from Blocktank. It loses its @staging tags because staging has no local LND; the channel-close-to-Taproot check is unchanged.
  • @settings_12 dismisses and restores the hardware wallet suggestion card instead of the removed Lightning card.
  • @hardware_wallet_3 now checks that the hardware wallet's Transfer To Spending opens the same sheet and leaves the balance untouched.
  • @transfer_2 (external node) is unchanged: Lightning Connections › add connection still reaches Manual Setup through FundManual.

Not changed:

  • The migration specs still buy channels on the old React Native app and on the pinned previous native release, which keep working while Blocktank staging does.
  • qa-fixture.ts still uses transferSavingsToSpending for its spending fixtures, so those fixture kinds won't work on builds with the app change until they get another channel source.

Checked locally with tsc --noEmit and eslint; the one remaining eslint error, prefer-const in send.e2e.ts, is also on main. The specs have not run yet: they run through the app PRs' E2E workflows, which pick this branch by name.

@ovitrif

ovitrif commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Closing with its app PRs synonymdev/bitkit-android#1670 and synonymdev/bitkit-ios#1102. Their replacements, synonymdev/bitkit-android#1696 and synonymdev/bitkit-ios#1127, only gate transfers when geo-blocked, and the E2E builds run with GEO=false, so the existing transfer tests stay valid.

@ovitrif ovitrif closed this Oct 26, 2026
@ovitrif
ovitrif deleted the feat/stop-new-channels branch October 26, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant