Repository navigation
Conversation
This was referenced Oct 24, 2026
Collaborator
Author
|
Closing with its app PRs synonymdev/bitkit-android#1670 and synonymdev/bitkit-ios#1102. Their replacements, synonymdev/bitkit-android#1696 and synonymdev/bitkit-ios#1127, only gate transfers when geo-blocked, and the E2E builds run with GEO=false, so the existing transfer tests stay valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion:
Updates the E2E suite for the app PRs that stop Bitkit from buying Blocktank channels. Transfer To Spending now opens a "Transfer Unavailable" sheet, Continue leads to a "Choose a Lightning provider" screen (third-party LSP links, Manual Setup, QR Code), and the Home "Spend" suggestion card is gone.
@transfer_1now checks that Transfer To Spending opens the sheet, that Cancel closes it, and that Continue shows four providers with Manual Setup opening the manual connection fields. The Blocktank purchase cases (the old@transfer_1and@transfer_max) are removed, since the app can no longer buy a channel.@multi_address_2opens its channel to the local LND node with all savings, through a newopenChannelToLndFromSavingshelper, instead of buying one from Blocktank. It loses its@stagingtags because staging has no local LND; the channel-close-to-Taproot check is unchanged.@settings_12dismisses and restores the hardware wallet suggestion card instead of the removed Lightning card.@hardware_wallet_3now checks that the hardware wallet's Transfer To Spending opens the same sheet and leaves the balance untouched.@transfer_2(external node) is unchanged: Lightning Connections › add connection still reaches Manual Setup throughFundManual.Not changed:
qa-fixture.tsstill usestransferSavingsToSpendingfor its spending fixtures, so those fixture kinds won't work on builds with the app change until they get another channel source.Checked locally with
tsc --noEmitandeslint; the one remaining eslint error,prefer-constinsend.e2e.ts, is also on main. The specs have not run yet: they run through the app PRs' E2E workflows, which pick this branch by name.