Repository navigation
fix: let incoming lightning use the whole channel - #1086
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8541ff1d06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Moves LDK Node from 0.7.0-rc.76 to 0.7.0-rc.77 so incoming Lightning payments can use the whole channel on new channels. Reviewed 4997c7c, full tier (dependency pin). Reasoned from the code and CI: iOS does not build on this reviewer's Linux host.
What I checked
Read in full: the 4 changed files; git grep rc.76 at the head finds no remaining pin.
Pin: exactVersion 0.7.0-rc.77 in the project matches Package.resolved, whose revision f05161e is the commit the v0.7.0-rc.77 tag in synonymdev/ldk-node points to (that tag's Package.swift checksum matches its published xcframework asset).
Upstream delta: rc.77 is rc.76 plus synonymdev/ldk-node#120 only, which touched no bindings, so no Swift call site here can break.
CI: SwiftFormat and validate green; Run Tests and build-local were still running when I read them.
Merge confidence: 4/5, a dependency bump not built here, with Run Tests still pending and the rc.76 upgrade path (manual test 2) not run yet.
[Medium impact] The PR appears safe to merge, with no actionable issues found. SummaryUpdates
Reviews (1) · Last reviewed commit: "chore: rename changelog fragment" · Reviewed by Greptile |
|
Pushed 012fdf8: adds the journey |
pwltr
left a comment
There was a problem hiding this comment.
Approved. The exact rc.77 requirement and resolved commit match the published LDK Node release, and Bitkit’s node configuration activates the increased inbound limit. No API changes or blocking integration findings. Existing channels retain their negotiated limit; newly opened channels get the change.
Build, unit tests, integration tests, formatting and E2E are green. Approval is based on source/dependency review and CI; device journey J1 and upgrade check 2 remain unverified as documented in the QA notes.
|
Put on 3.1.0: merged to master for the next release. |
Fixes #850
Twin: synonymdev/bitkit-android#1662
Refs: synonymdev/ldk-node#120
This PR updates LDK Node from
0.7.0-rc.76to0.7.0-rc.77, so incoming Lightning payments can use the whole channel instead of 10% of it.Description
0.7.0-rc.77(release), which accepts incoming payments up to the full channel value on nodes that cannot announce channels, as Bitkit's node. Before, a single payment above 10% of the channel failed with no route.0.7.0-rc.77is0.7.0-rc.76plus fix: let unannounced channels take full-size payments ldk-node#120; no API changes.Out of Scope
Design
N/A — no UI changes.
Preview
N/A — no user-visible UI change.
QA Notes
Setup
Regtest or staging with an LSP channel opened after installing this build.
Journeys
receive-above-ten-percent-of-channel.xml— on a channel opened by this build, a single Lightning payment above 10% of the channel arrivesManual Tests
0.7.0-rc.76with an existing wallet and channels → the node starts, channels reconnect, balances match — upgrade path not in CapabilitiesAutomated Checks
xcodebuild -resolvePackageDependencies— resolvesldk-nodeat0.7.0-rc.77;Package.resolvedpins the release tag's commitf05161edEvidence
Gaps
Models used
claude-opus-5-5(reasoning: Not exposed)claude-opus-5-5(reasoning: Not exposed)