Skip to content

fix: let incoming lightning use the whole channel - #1086

Merged
ovitrif merged 3 commits into
masterfrom
fix/ldk-node-rc77-full-inbound
Oct 22, 2026
Merged

ovitrif merged 3 commits into
masterfrom
fix/ldk-node-rc77-full-inbound

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #850

Twin: synonymdev/bitkit-android#1662
Refs: synonymdev/ldk-node#120

This PR updates LDK Node from 0.7.0-rc.76 to 0.7.0-rc.77, so incoming Lightning payments can use the whole channel instead of 10% of it.

Description

Out of Scope

  • Existing channels: the limit is set when a channel opens, so channels opened before this update keep the 10% limit until they are closed and reopened.

Design

N/A — no UI changes.

Preview

N/A — no user-visible UI change.

QA Notes

Setup

Regtest or staging with an LSP channel opened after installing this build.

Journeys

  • J1: new receive-above-ten-percent-of-channel.xml — on a channel opened by this build, a single Lightning payment above 10% of the channel arrives

Manual Tests

  • 2. Upgrade from a build on 0.7.0-rc.76 with an existing wallet and channels → the node starts, channels reconnect, balances match — upgrade path not in Capabilities

Automated Checks

  • ran xcodebuild -resolvePackageDependencies — resolves ldk-node at 0.7.0-rc.77; Package.resolved pins the release tag's commit f05161ed

Evidence

Gaps

  • J1 and manual test 2 not run on a device yet.
  • Manual test 1 is retired: J1 covers it, since the LSP node pays from the journey harness.

Models used

  • Planning/scoping: claude-opus-5-5 (reasoning: Not exposed)
  • Implementation: claude-opus-5-5 (reasoning: Not exposed)
  • Review: Not performed

@ovitrif ovitrif self-assigned this Oct 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T16:39:07.494996Z 8541ff1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from a team, ben-kaufman and pwltr and removed request for a team October 21, 2026 16:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8541ff1d06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Bitkit.xcodeproj/project.pbxproj

@talosmachina talosmachina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Moves LDK Node from 0.7.0-rc.76 to 0.7.0-rc.77 so incoming Lightning payments can use the whole channel on new channels. Reviewed 4997c7c, full tier (dependency pin). Reasoned from the code and CI: iOS does not build on this reviewer's Linux host.

What I checked

Read in full: the 4 changed files; git grep rc.76 at the head finds no remaining pin.
Pin: exactVersion 0.7.0-rc.77 in the project matches Package.resolved, whose revision f05161e is the commit the v0.7.0-rc.77 tag in synonymdev/ldk-node points to (that tag's Package.swift checksum matches its published xcframework asset).
Upstream delta: rc.77 is rc.76 plus synonymdev/ldk-node#120 only, which touched no bindings, so no Swift call site here can break.
CI: SwiftFormat and validate green; Run Tests and build-local were still running when I read them.

Merge confidence: 4/5, a dependency bump not built here, with Run Tests still pending and the rc.76 upgrade path (manual test 2) not run yet.

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no actionable issues found.

Summary

Updates ldk-node from 0.7.0-rc.76 to 0.7.0-rc.77 to allow larger incoming Lightning payments on newly opened channels.

  • New Bitkit channels can receive payments up to their full value.

Reviews (1) · Last reviewed commit: "chore: rename changelog fragment" · Reviewed by Greptile

@ovitrif

ovitrif commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Pushed 012fdf8: adds the journey receive-above-ten-percent-of-channel.xml (J1), which receives a payment above 10% of a newly opened channel, paid from the LSP node. Manual test 1 is retired in its favour; the QA notes are updated.

@pwltr pwltr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The exact rc.77 requirement and resolved commit match the published LDK Node release, and Bitkit’s node configuration activates the increased inbound limit. No API changes or blocking integration findings. Existing channels retain their negotiated limit; newly opened channels get the change.

Build, unit tests, integration tests, formatting and E2E are green. Approval is based on source/dependency review and CI; device journey J1 and upgrade check 2 remain unverified as documented in the QA notes.

@ovitrif
ovitrif merged commit a4cab1c into master Oct 22, 2026
19 checks passed
@ovitrif
ovitrif deleted the fix/ldk-node-rc77-full-inbound branch October 22, 2026 14:39
@ovitrif ovitrif added this to the 3.1.0 milestone Oct 22, 2026
@ovitrif

ovitrif commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Put on 3.1.0: merged to master for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: incoming lightning payments above 10% of the channel size fail

3 participants