Repository navigation
fix: serialize elements iteratively so deep nesting does not overflow the stack - #326
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324
HTMLElement.toString()andinnerHTMLcalled each other recursively, so serializing a tree nested a few thousand levels deep threwRangeError: Maximum call stack size exceeded, whileparse()handled it fine. Both now go through one iterative serializer with an explicit stack. The output is the same: void tags still go throughvoidTag.formatNode(soaddClosingSlashand custom void tags keep working), other elements get<tag attrs>…</tag>, and text and comment nodes use their owntoString().Added
test/tests/issues/324.js(depth 10000 round trip fortoString,outerHTMLandinnerHTML, plus a mixed void tag / comment / attribute case). Withnpm run test:srcthe new tests pass; the twoModule Importfailures are the same with and without this change (they need the built package).