Repository navigation
Conversation
khisakuni
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds support for disabling standalone activity export
Why?
Checklist
Closes
How was this tested:
Note
Medium Risk
Changes how export sink specs are built and sent to Temporal Cloud; incorrect filter merge on update could alter what data is exported, though behavior is covered by extensive tests.
Overview
Adds
--disable-standalone-activity-exporton S3, GCS, and Azure Blob namespace export create, update, and validate commands so customers can turn off standalone activity events while workflow history export stays the same. On update, the flag is only applied when explicitly set; omitting it leaves the current filter unchanged, and=falsecan re-enable export.Bumps
go.temporal.io/cloud-sdkto v0.22.0 for the newExportSinkSpecfilter field.Refactors export sink create/update/validate: removes the shared per-backend helpers, inlines command handlers, and switches to
GetCloudClient/ async poller handling. Tests are consolidated into table-driven coverage across all three backends, including filter omission vs explicit true/false.Reviewed by Cursor Bugbot for commit 0b069bf. Bugbot is set up for automated code reviews on this repo. Configure here.