Repository navigation
Test custom slot supplier slot info fields - #2048
Merged
tconley1428 merged 1 commit intoOct 30, 2026
Merged
Conversation
|
|
tconley1428
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
test_custom_slot_suppliernow runs a local activity too, records the reserved slot type on the permit, and checks the slot info fields on used and released slots: workflow type and sticky flag, activity type for both activity kinds, and Nexus service and operation.Why?
The test only checked which slot kinds showed up in
mark_slot_used, not the fields on the slot info, and it never ran a local activity. Activity and local activity slot infos have the same shape, so the oldisinstancechecks couldn't tell them apart either. The new checks run after the worker stops, because exceptions inside supplier callbacks are logged and swallowed, so asserting inside the callbacks could never fail the test.Checklist
Closes [Feature Request] Ensure tests exist to confirm custom slot supplier slot info has proper fields #1079
How was this tested:
poe test -k test_custom_slot_supplier --flake-finder --flake-runs=3passes locally against the dev server (6 passed), and changing one expected value makes it fail as it should.poe lintpasses.Any docs updates needed?
No. Test-only, so no changelog fragment.