Skip to content

Test custom slot supplier slot info fields - #2048

Merged
tconley1428 merged 1 commit into
temporalio:mainfrom
dalindev:test/slot-supplier-info-fields
Oct 30, 2026
Merged

tconley1428 merged 1 commit into
temporalio:mainfrom
dalindev:test/slot-supplier-info-fields

Conversation

@dalindev

@dalindev dalindev commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

test_custom_slot_supplier now runs a local activity too, records the reserved slot type on the permit, and checks the slot info fields on used and released slots: workflow type and sticky flag, activity type for both activity kinds, and Nexus service and operation.

Why?

The test only checked which slot kinds showed up in mark_slot_used, not the fields on the slot info, and it never ran a local activity. Activity and local activity slot infos have the same shape, so the old isinstance checks couldn't tell them apart either. The new checks run after the worker stops, because exceptions inside supplier callbacks are logged and swallowed, so asserting inside the callbacks could never fail the test.

Checklist

  1. Closes [Feature Request] Ensure tests exist to confirm custom slot supplier slot info has proper fields #1079

  2. How was this tested:
    poe test -k test_custom_slot_supplier --flake-finder --flake-runs=3 passes locally against the dev server (6 passed), and changing one expected value makes it fail as it should. poe lint passes.

  3. Any docs updates needed?
    No. Test-only, so no changelog fragment.

@dalindev
dalindev requested a review from a team as a code owner October 30, 2026 00:14
@CLAassistant

CLAassistant commented Oct 30, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tconley1428 tconley1428 added the skip-changelog PR changes do not require changelog updates label Oct 30, 2026
@tconley1428
tconley1428 merged commit 2859875 into temporalio:main Oct 30, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog PR changes do not require changelog updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Ensure tests exist to confirm custom slot supplier slot info has proper fields

3 participants