Repository navigation
Keep converter serialization context when external storage is enabled - #2050
Merged
tconley1428 merged 1 commit intoOct 30, 2026
Merged
tconley1428 merged 1 commit into
tconley1428 merged 1 commit into
Conversation
tconley1428
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
With external storage configured, the payload converter and failure converter lose their serialization context.
_with_contextscallswith_context()and then_with_store_context(). The second step usesdataclasses.replace, which reruns__post_init__and builds new payload and failure converters from their classes, so the context-bound instances are dropped. Only the codec keeps its context, because it's an init field.So any converter that implements
WithSerializationContextgetsNoneinstead of the workflow or activity context on client calls and in the workflow and activity workers, as soon as external storage is set. This happens for every payload, not just those that go to storage.The fix keeps the current converters on the clone, as
with_context()does.How was this tested
Parametrized
test_payload_conversion_calls_follow_expected_sequence_and_contextsto also run with external storage (in-memory driver). On main, the new case fails with "Unexpected context type: NoneType" in the payload converter. With the fix, both cases pass. The rest of test_serialization_context.py and the extstore and converter tests pass the same as on main.