Repository navigation
fix: Avoid cleanup error when the container is document - #1473
Open
mkantautas wants to merge 1 commit into
Open
mkantautas wants to merge 1 commit into
mkantautas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fixes #1329:
cleanup()throwsTypeError: Cannot read properties of null (reading 'removeChild')after rendering or hydrating intocontainer: documentwith React 18.Why:
On React 18, unmounting a root rendered into
documentremoves the<html>element, sodocument.bodyisnull.document.parentNodeis alsonull, socontainer.parentNode === document.bodyis true anddocument.body.removeChildthrows. The test fails in the auto-cleanupafterEacheven though its assertions passed. React 19 keeps<html>/<body>as singletons, which is why this does not reproduce with the default React 19 setup.How:
Only remove the container from
document.bodywhendocument.bodyexists. Added tests incleanup.jsthat render and hydrate intodocumentand then callcleanup(). They fail without the fix in the React 18 jobs (both throw the error above) and pass on React 19 with or without it.Checklist:
docs site N/A