Repository navigation
keep DateTimeImmutable inner and outer dates in sync, fixes #759 - #760
Merged
shish merged 1 commit intoOct 24, 2026
Merged
Conversation
JoniJnm
force-pushed
the
fix/759-datetimeimmutable-constructor
branch
from
October 16, 2026 11:38
9212305 to
7487888
Compare
Collaborator
|
Looks good, the tests failing seem unrelated to your changes so I'm not sure why they just started failing now... |
…machine#759 The constructor created the parent and the inner \DateTimeImmutable separately, so relative times like 'now' could differ by microseconds between the two, breaking diff() and comparisons. Build the inner date first and initialise the parent from its exact value and timezone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shish
force-pushed
the
fix/759-datetimeimmutable-constructor
branch
from
October 24, 2026 12:48
7487888 to
d6f421e
Compare
Collaborator
|
Fixed the tests which were broken upstream, all green, merging now, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor created the parent and the inner \DateTimeImmutable separately, so relative times like 'now' could differ by microseconds between the two, breaking diff() and comparisons. Build the inner date first and initialise the parent from its exact value and timezone.
fixes #759