Repository navigation
Handle CRLF invalid lines in parser recovery - #669
Merged
Merged
Conversation
bbc2
force-pushed
the
codex/preserve-cr-newline
branch
from
October 28, 2026 14:10
9392b5b to
7123417
Compare
Collaborator
|
Thanks, I just added a test inspired by #722. |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the parser recovery regex for invalid lines so CRLF is consumed as one newline sequence, matching the parser's other newline handling.
Why
When an invalid
.envline used CRLF line endings,_rest_of_linematched\rbefore\r\n. That left the\nbehind for the next parse iteration, so recovery could produce an extra blank binding before the following valid line.Validation
PYTHONPATH=src python -m pytest tests\test_parser.py::test_parse_stream -qPYTHONPATH=src python -m pytest tests\test_parser.py -qpython -m ruff check src\dotenv\parser.py tests\test_parser.pygit diff --check