Skip to content

fix(main): support character devices in _is_file_or_fifo #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voidstackloop wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −2
Open

fix(main): support character devices in _is_file_or_fifo #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20c951b
fix(main): support character devices in _is_file_or_fifo
voidstackloop Oct 27, 2026
54588c4
style(tests): fix ruff format in test_fifo_dotenv
voidstackloop Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dotenv/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def dotenv_values(

def _is_file_or_fifo(path: StrPath) -> bool:
"""
Return True if `path` exists and is either a regular file or a FIFO.
Return True if `path` exists and is either a regular file, a FIFO, or a character device.
"""
if os.path.isfile(path):
return True
Expand All @@ -529,4 +529,4 @@ def _is_file_or_fifo(path: StrPath) -> bool:
except (FileNotFoundError, OSError):
return False

return stat.S_ISFIFO(st.st_mode)
return stat.S_ISFIFO(st.st_mode) or stat.S_ISCHR(st.st_mode)
9 changes: 9 additions & 0 deletions tests/test_fifo_dotenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logging
import os
import pathlib
import sys
Expand Down Expand Up @@ -29,3 +30,11 @@ def writer():

assert ok is True
assert os.getenv("MY_PASSWORD") == "pipe-secret"


def test_load_dotenv_from_devnull(caplog):
with caplog.at_level(logging.INFO):
ok = load_dotenv(dotenv_path=os.devnull, verbose=True)

assert ok is False
assert "could not find configuration file" not in caplog.text
Loading