Repository navigation
fix: preserve aware datetime instants during UTC serialization - #981
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
The shared handwritten ISO8601 datetime serializer currently discards UTC offsets while appending
Z. For example, a scheduled-messagesend_atof2030-01-02 01:30+05:30becomes2030-01-02T01:30:00Z, shifting the requested instant by 5.5 hours.Convert aware datetimes to UTC before formatting. Keep the existing naive/date/string/unset behavior. Document the conversion in the serializer and add six tests through the public
Client.messages.createAPI using a mocked HTTP transport, including positive/negative offsets across date boundaries and four compatibility controls. No generated REST files are changed.Validation: two regressions fail before the fix and four controls pass. Full required
make testpasses on Python3.12:647 tests, source/test Flake8, Autoflake, and Black (797 files). No live Twilio requests/messages or full Python matrix run. AI-assisted contribution; maintainer review pending.Checklist