Repository navigation
Stop a child from its own invocation's turn without hanging - #248
Merged
Merged
Conversation
Since 0.45.0 an idle machine's worker starts in the sender's turn. When a child's invocation completed, its onDone ran inside the invocation fiber, and a parent that stopped the child in response requested an interrupt there. The invocation fiber then waited for the child's worker, which was waiting for the invocation fiber to exit. The interruption now runs in its own fiber, while whoever requested the stop awaits completion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDonesends to its parent and the parent's transition stops that child, the stop asked to interrupt the worker from inside the invocation fiber. The invocation fiber then waited for the child's worker, and the worker was waiting for the invocation fiber to exit, so both machines hung, including scope finalization.startWorkernow forks the requested interruption instead of awaiting it in the sender's turn. Whoever requested the stop already awaits completion.main.Changeset
Validation
pnpm checkpnpm perf:runtimealso completed locally. A consumer app's machine tests that hung on 0.45.0 pass with this build: 357/357.🤖 Generated with Claude Code