Skip to content

test(e2e): Cover queue pause and freeze across every switch combination - #870

Merged
manjari25 merged 7 commits into
mainfrom
manjari/queue-pause-5-e2e
Oct 15, 2026
Merged

manjari25 merged 7 commits into
mainfrom
manjari/queue-pause-5-e2e

Conversation

@manjari25

@manjari25 manjari25 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Queue pause is two independent switches, reject new lands and freeze processing. The unit tests cover each in isolation, but nothing yet proves that the switches work together, that a freeze really holds a queue's pipeline, or that a rejection reaches a caller as the right status with the operator's reason.

What?

  • Adds e2e tests for all four switch combinations: running, drain (reject only), hold (freeze only) and full pause.
  • A frozen request is shown to be held, not merely slow: a request on an unpaused sentinel queue must land first while the frozen one stays accepted.
  • A rejected land is checked for FailedPrecondition, and the full-pause test also checks that the operator's reason reaches the caller.
  • Compose wiring: the gateway and orchestrator read QUEUE_PAUSE_CONFIG_PATH from a mounted directory, and a dedicated e2e-pause-queue is added. Pausing stays off by default, so the local stack starts as before.
  • The tests replace the pause file by rename inside the mounted directory, so a reader sees the old or new contents and never a parti

Test Plan

  • bazel test //test/e2e/submitqueue:go_default_test --test_arg=-testify.m=TestQueuePause runs the four pause tests.
  • CI

Issue

@manjari25
manjari25 added this pull request to stack #868 October 14, 2026 20:53
@manjari25
manjari25 marked this pull request as ready for review October 14, 2026 22:04
@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners October 14, 2026 22:04
@behinddwalls
behinddwalls added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 15, 2026
@manjari25
manjari25 added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue because a pull request earlier in the stack was removed Oct 15, 2026
@manjari25
manjari25 force-pushed the manjari/queue-pause-5-e2e branch from a0a75be to 665054c Compare October 15, 2026 22:15
@manjari25
manjari25 added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit ef9dd35 Oct 15, 2026
19 checks passed
Base automatically changed from manjari/queue-pause-4-freeze-gate to main October 15, 2026 22:57
@manjari25
manjari25 deleted the manjari/queue-pause-5-e2e branch October 15, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants