Repository navigation
test(e2e): Cover queue pause and freeze across every switch combination - #870
Merged
Merged
Conversation
manjari25
added this pull request to stack #868
October 14, 2026 20:53
manjari25
marked this pull request as ready for review
October 14, 2026 22:04
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 14, 2026 22:04
behinddwalls
approved these changes
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because a pull request earlier in the stack was removed
Oct 15, 2026
manjari25
force-pushed
the
manjari/queue-pause-5-e2e
branch
from
October 15, 2026 22:15
a0a75be to
665054c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Queue pause is two independent switches, reject new lands and freeze processing. The unit tests cover each in isolation, but nothing yet proves that the switches work together, that a freeze really holds a queue's pipeline, or that a rejection reaches a caller as the right status with the operator's reason.
What?
accepted.FailedPrecondition, and the full-pause test also checks that the operator'sreasonreaches the caller.QUEUE_PAUSE_CONFIG_PATHfrom a mounted directory, and a dedicatede2e-pause-queueis added. Pausing stays off by default, so the local stack starts as before.Test Plan
bazel test //test/e2e/submitqueue:go_default_test --test_arg=-testify.m=TestQueuePauseruns the four pause tests.Issue