Repository navigation
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 18:41
roychying
added this pull request to stack #880
October 16, 2026 18:43
roychying
force-pushed
the
chenghan.ying/github-validator
branch
from
October 16, 2026 18:57
d569932 to
d803dd4
Compare
…idator in the orchestrator profiles
roychying
force-pushed
the
chenghan.ying/github-validator
branch
from
October 16, 2026 18:58
d803dd4 to
80a785b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
SubmitQueue only rejects a GitHub pull request at validation for what the merger's mergeability check catches: closed, draft, conflicting, wrong stack shape or target. A pull request that is missing a required review or has a failing or still-running required check is accepted, batched and built. It then fails at land time, when GitHub refuses the merge, after holding up the queue.
Every queue in the example orchestrator also gets the always-passing fake validator, with no way to choose a real one per queue.
What?
submitqueue/extension/validator/github: avalidator.Validatorthat asks GitHub whether each pull request could merge under the repository's own branch protection or rulesets. Nothing is restated in SubmitQueue config. For eachgithub://URI, bottom of the stack first, it reads the pull request in one GraphQL call and rejects at the first rule it breaks:hoststaleCHANGES_REQUESTED/REVIEW_REQUIREDnot_approvedcheck_failed/check_pendingBLOCKED(catches what the rules above can't see, e.g. a required check that hasn't reported yet)blockedUNKNOWNmerge state, no review rule) passes. GitHub enforces the same rules again when it merges.composite.*http.Client, the same contract as the GitHub change provider and merger.platform/http.StatusErrorin the chain forplatform/errs/http. Neither is classified here, as for any extension.validate.finishcounts only read failures as errors.validate.rejectionsis also tagged by reason.Orchestrator wiring (
service/submitqueue/orchestrator/server):validator:block,{type: fake|github}withtokenEnv,baseUrl,hostandtimeout. These default toGITHUB_TOKEN,https://api.github.comandgithub.com.fake, so existing queues and the built-in example setup are unchanged.validatorFactoryinmain.go.githubvalidator whose token is unset fails at startup.Test Plan
bazel test //submitqueue/extension/validator/... //service/submitqueue/orchestrator/server:all make lint check-gazelle check-mocks check-tidyIssue