Skip to content

fix(plugins): cfg-gate non-Windows hook path import - #3302

Merged
Yeachan-Heo merged 1 commit into
ultraworkers:mainfrom
dajiaohuang:fix/windows-clippy-hooks-import
Oct 19, 2026
Merged

Yeachan-Heo merged 1 commit into
ultraworkers:mainfrom
dajiaohuang:fix/windows-clippy-hooks-import

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Gate the non-Windows-only Path import in the plugin hook runner.
  • Keep non-Windows behavior unchanged while allowing Windows strict clippy to compile the plugins crate.

Anti-slop triage

  • Classification: actionable-fix
  • Evidence: Windows cargo clippy --workspace --all-targets -- -D warnings reported
    ust/crates/plugins/src/hooks.rs:2 as an unused import; the targeted plugins clippy check passes after this change.
  • Non-destructive review result: merge candidate

Verification

  • cargo fmt --all --check
  • cargo check -p plugins
  • cargo clippy -p plugins --all-targets -- -D warnings
  • git diff --check
  • No secrets, tokens, private logs, or unrelated generated files are included.
  • Full workspace test/clippy runs remain blocked by existing Windows-incompatible Unix-only tests and unrelated pre-existing diagnostics outside this one-line fix.

Resolution gate

  • Standalone cross-platform lint fix; no issue link is required.
  • I did not merge or close remote PRs or issues.

@XinwangTao

Copy link
Copy Markdown

Thanks for the fix. On Windows the unused Path import indeed trips cargo clippy -D warnings, so cfg-gating it is the right call. Non-Windows behavior stays untouched and the targeted clippy check passing confirms it.

@XinwangTao

Copy link
Copy Markdown

修复方向正确。建议在 Windows CI 工作流中补上 cargo clippy -p plugins --all-targets -- -D warnings,避免这类 Unix-only import 问题将来回归。

@dajiaohuang

Copy link
Copy Markdown
Contributor Author

Thanks — the targeted Windows clippy check passes for this change. Adding a new Windows CI workflow is broader than the import fix and would need maintainer direction, so I left CI unchanged.

@XinwangTao

Copy link
Copy Markdown

可以合并,本 PR 保持 CI 不变即可。Windows 侧补 clippy 检查作为后续单独增强跟踪,不阻塞这个 import 修复。

@XinwangTao

Copy link
Copy Markdown

确认:本 PR 就绪,我可以合并。Windows 侧补 clippy 检查(-p plugins --all-targets -- -D warnings)作为后续 CI 增强单独跟踪,不阻塞本 import 修复。

cultosagent added a commit to cultosagent/dogma-registry that referenced this pull request Sep 26, 2026
@Yeachan-Heo
Yeachan-Heo force-pushed the fix/windows-clippy-hooks-import branch from b1311dc to 51b6a20 Compare October 19, 2026 03:01
@Yeachan-Heo
Yeachan-Heo merged commit 917a9e2 into ultraworkers:main Oct 19, 2026
@Yeachan-Heo

Copy link
Copy Markdown
Contributor

Merged! Rebased on latest main (6d7412d) and verified locally with cargo fmt/clippy/test. The cfg-gate for the non-Windows Path import resolves the Windows clippy warning as intended.

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo Yeachan-Heo mentioned this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants