Skip to content

fix(workflow): repair binding validation and report previews - #100

Merged
viktar-b merged 2 commits into
mainfrom
codex/five-issue-fixes
Nov 1, 2026
Merged

viktar-b merged 2 commits into
mainfrom
codex/five-issue-fixes

Conversation

@viktar-b

@viktar-b viktar-b commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes #56, fixes #58, fixes #39, fixes #41, fixes #89.

bindings       reject module/package import collisions before writes
Python tests   check generated interfaces with pinned mypy consumers
MathML         separate branches; size scripts relative to their parent
dev-render     warn when the math-only preview omits authored content

The development renderer uses #89's explicitly allowed warning-based resolution. It identifies omitted item kinds/counts and points to the complete HTML/PDF commands while retaining its separate unverified numerical status.

Evidence

  • Before: colliding calculation/package names generated successfully but could not be imported. After: flat/nested conflicts fail in generation and check mode, preserve prior output, and valid generated imports still work.
  • Before: generated Python stubs had no checker-consumer coverage. After: pinned mypy accepts valid/defaulted/nested float/int consumers and rejects each specified misuse by file, line and error code. An Any mutation removes the expected failures and is detected. CI, isolated and installed consumers use the same test-only requirements; runtime dependencies remain empty.
  • Before: conditional branches crowded together and transformed/fixed-size exponents detached or became inconsistent. After: Chromium screen/print regressions measure branch clearance, horizontal label separation, exponent attachment, grouping and script sizes. Removed inner 15px resets and CSS scaling; nested scripts/fractions inherit relative sizes with an 8px minimum.
  • Before: dev-render silently omitted assumptions/reference prose. After: an installed archive consumer renders a PDF successfully and checks the explicit text: 2 omission warning and numerical-status wording.

Validation: workspace lint/typechecks and package suites; 190 Python tests; 339 integration tests; all six isolated projects; installed CLI/archive/wheel consumers; library archive consumers; CI classifier and PR title tests. Fresh-project initializer acceptance and the production demo build also pass. The initializer retry passed after task-owned disposable test dependencies were removed to recover local disk space.

Visual inspection: Chromium screen/print layouts and every page of the synthetic spacing PDF and affected conditional-method PDF were inspected. The latter can continue its final result onto a second page; the regression now checks page count and retained content. Firefox/WebKit are not installed locally. These layout fixtures do not establish engineering approval.

Merge Danger

Door: two-way

Blast Radius: rendering

Script sizing also affects qualified glyphs and units inside reports. Clearer conditional spacing can increase pagination. Binding collisions that previously appeared successful now return an actionable error. No numerical formulas or runtime dependencies change.

viktar-b commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
calculation-source-object Ready Ready Preview Nov 1, 2026 8:53pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T20:55:42.718713Z 4638b0c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: cca6631b63

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viktar-b commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Increased conditional cell padding to retain the existing 4px minimum branch-clearance check with Ubuntu's fallback math fonts. The acceptance threshold is unchanged. All 13 focused spacing/method-table tests pass locally; CI is rerunning on the updated head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 4638b0cada

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@viktar-b
viktar-b merged commit 699cd35 into main Nov 1, 2026
14 checks passed
@viktar-b
viktar-b deleted the codex/five-issue-fixes branch November 1, 2026 21:11

This branch was successfully deployed

1 active deployment
Preview — 4638b0ca Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant