Repository navigation
fix(workflow): repair binding validation and report previews - #100
Conversation
|
@codex review |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Increased conditional cell padding to retain the existing 4px minimum branch-clearance check with Ubuntu's fallback math fonts. The acceptance threshold is unchanged. All 13 focused spacing/method-table tests pass locally; CI is rerunning on the updated head. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Fixes #56, fixes #58, fixes #39, fixes #41, fixes #89.
The development renderer uses #89's explicitly allowed warning-based resolution. It identifies omitted item kinds/counts and points to the complete HTML/PDF commands while retaining its separate unverified numerical status.
Evidence
Anymutation removes the expected failures and is detected. CI, isolated and installed consumers use the same test-only requirements; runtime dependencies remain empty.dev-rendersilently omitted assumptions/reference prose. After: an installed archive consumer renders a PDF successfully and checks the explicittext: 2omission warning and numerical-status wording.Validation: workspace lint/typechecks and package suites; 190 Python tests; 339 integration tests; all six isolated projects; installed CLI/archive/wheel consumers; library archive consumers; CI classifier and PR title tests. Fresh-project initializer acceptance and the production demo build also pass. The initializer retry passed after task-owned disposable test dependencies were removed to recover local disk space.
Visual inspection: Chromium screen/print layouts and every page of the synthetic spacing PDF and affected conditional-method PDF were inspected. The latter can continue its final result onto a second page; the regression now checks page count and retained content. Firefox/WebKit are not installed locally. These layout fixtures do not establish engineering approval.
Merge Danger
Door: two-way
Blast Radius: rendering
Script sizing also affects qualified glyphs and units inside reports. Clearer conditional spacing can increase pagination. Binding collisions that previously appeared successful now return an actionable error. No numerical formulas or runtime dependencies change.