feat(external): support documented adapters across verified reports by viktar-b · Pull Request #99 · viktar-b/CalculationSourceObject

viktar-b · 2026-11-01T12:47:48Z

Summary

Support documented external Python adapters through static declarations, captured named results, scoped independent references, and retained HTML/PDF reports.

declaration -> generated handle -> one captured adapter call
Core -> boundary consistency + scoped references + downstream formulas
React / CLI -> ordinary indexed quantity rows + complete case blocks

PR #98 is integrated. Accepted Q30-Q32 are implemented: static external leaves inside methods and empty tables, complete per-case blocks after grouping, and conservative applicability through every external input with branch-aware downstream formulas and retained failed checks.

Inputs and outputs use the ordinary description, variable, value, unit and comment cells. Captures preserve every quantity, source/adapter identity, native numeric kinds, diagnostics and state scoped to each run. Static planning and saved report rendering never execute adapters. Reports separate boundary consistency, formula checks and partial independent coverage, and explicitly exclude the external algorithm.

External evidence uses execution/prepared version 4 and CSO 1.2.0. Historical supported pure-CSO formats retain their meanings; lossy external exports reject early. Whole-run deadlines preserve successful artifacts after later failures. Coordinated packages and initializer pins are 1.0.0. Canonical loop and optional SciPy examples have separately derived expectations. Registry publication remains a separate release workflow.

Refs #54.

Evidence

Before: external declarations and mixed method/table calls were unsupported. After: capture, verification, grouped-case rendering, scoped references and retained publication pass public regression tests.
Final verification passes: 182 Core, 56 React, 81 CLI, 9 demo and 5 initializer tests; 187 tests against the rebuilt Python wheel in an external consumer; all 338 integration tests.
Lint/typecheck, dependency audit, all five isolated projects, fresh npm archives/Python wheel, optional SciPy/NumPy boundaries, library ESM/CJS/types/browser consumers, generated-project acceptance and demo build pass. Full installed-archive acceptance ran locally; the PR classifier skips that hosted job.
Testers repaired package initializers, import containment, Unicode/output keys, warning/error context, timeout underflow, static prepared-input binding and browser selectors. Chained wrong answers now retain matching independent references and fail comparison, including through formulas/helpers.
Codex's receiver-collision finding is fixed. Both external and ordinary generated handles accept a declared self input, with failing-before/passing-after tests for top-level and nested calls.
Checked HTML/PDF retains all quantities, unused diagnostics, comments, units and source context. Every page of the installed loop/scientific PDFs and three-page long/mixed PDFs was visually inspected with separate exact-hash receipts. Continuations repeat call/source/exclusion.
Independent standards/spec reviews have no remaining findings. Final-head Codex review completed with no findings. CI, both Windows shells, CodeQL, dependency review and PR-title checks pass on 12f44d0. All review threads are resolved.

Merge Danger

Door: Two-way

Blast Radius: Reporting

Changes span Python capture, strict Core contracts, React preparation and CLI publication. Historical readers and pure-CSO behavior have explicit regressions. No data migration or registry publication is performed by this PR.

vercel · 2026-11-01T12:47:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
calculation-source-object	Ready	Preview	Nov 1, 2026 2:58pm UTC

viktar-b · 2026-11-01T13:37:33Z

@codex review

chatgpt-codex-connector · 2026-11-01T13:37:46Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T15:02:01.540638Z	`12f44d0`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97f9053d48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viktar-b · 2026-11-01T13:45:11Z

@codex review

chatgpt-codex-connector · 2026-11-01T13:48:42Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: c9b3b894f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viktar-b · 2026-11-01T14:40:43Z

@codex review

chatgpt-codex-connector · 2026-11-01T14:44:17Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: a2b0a44a9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viktar-b · 2026-11-01T14:47:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0d3106b1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viktar-b · 2026-11-01T14:55:11Z

@codex review

viktar-b · 2026-11-01T14:58:15Z

@codex review

chatgpt-codex-connector · 2026-11-01T15:02:00Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 12f44d0ad9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docs: separate external function design decisions

07bd23b

vercel Bot deployed to Preview November 1, 2026 12:47

View deployment

viktar-b changed the title ~~docs: record external function design decisions~~ docs(architecture): record external function design decisions Nov 1, 2026

viktar-b added 3 commits November 1, 2026 13:03

Merge main with method and table implementation into external functions

15a504d

feat(external): capture named adapter results through verified reports

e46fe1f

fix(external): preserve exact evidence and reuse indexed quantity rows

97f9053

viktar-b changed the title ~~docs(architecture): record external function design decisions~~ feat(external): capture named adapter results in verified reports Nov 1, 2026

vercel Bot deployed to Preview November 1, 2026 13:37

View deployment

chatgpt-codex-connector Bot reviewed Nov 1, 2026

View reviewed changes

Comment thread packages/cso-python/src/cso_python/bindings.py Resolved

fix(bindings): retain external package initializer handles

c9b3b89

vercel Bot deployed to Preview November 1, 2026 13:45

View deployment

feat(external): complete method composition and independent references

a2b0a44

viktar-b changed the title ~~feat(external): capture named adapter results in verified reports~~ feat(external): support documented adapters across verified reports Nov 1, 2026

vercel Bot deployed to Preview November 1, 2026 14:40

View deployment

fix(references): keep chained external answers outside matching identity

c0d3106

vercel Bot deployed to Preview November 1, 2026 14:47

View deployment

chatgpt-codex-connector Bot reviewed Nov 1, 2026

View reviewed changes

Comment thread packages/cso-python/src/cso_python/external.py Resolved

fix(external): accept self as a declared keyword input

eec7b0b

vercel Bot deployed to Preview November 1, 2026 14:53

View deployment

viktar-b marked this pull request as ready for review November 1, 2026 14:55

fix(handles): preserve self keyword inputs in generated calculations

12f44d0

vercel Bot deployed to Preview November 1, 2026 14:58

View deployment

viktar-b merged commit f28c96d into main Nov 1, 2026
15 checks passed

viktar-b deleted the codex/external-function-decisions branch November 1, 2026 15:05

This was referenced Nov 1, 2026

Introduce imported black box calculation functions #54

Closed

fix: allow calculation inputs named self through generated handles #57

Closed

Conversation

viktar-b commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Evidence

Merge Danger

Uh oh!

vercel Bot commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

viktar-b commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

viktar-b commented Nov 1, 2026 •

edited

Loading

vercel Bot commented Nov 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 1, 2026 •

edited

Loading